From db8e26b60e1d3a81580d21f90ea46d63e3c50fb8 Mon Sep 17 00:00:00 2001 From: tobi Date: Wed, 15 Oct 2025 10:52:21 +0200 Subject: [chore/performance] Use CTE for list select statuses query (#4501) # Description > If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements. > > If this is a documentation change, please briefly describe what you've changed and why. This PR changes the list select query to use (potentially cached) account IDs provided in a CTE, rather than using a subquery that joins on the follows table. This should be a little faster! ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [x] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4501 Co-authored-by: tobi Co-committed-by: tobi --- internal/db/bundb/util.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'internal/db/bundb/util.go') diff --git a/internal/db/bundb/util.go b/internal/db/bundb/util.go index d0d25a236..39849ba73 100644 --- a/internal/db/bundb/util.go +++ b/internal/db/bundb/util.go @@ -240,3 +240,9 @@ func whereArrayIsNullOrEmpty(query *bun.SelectQuery, subject interface{}) *bun.S WhereOr(arrayEmptySQL, subject) }) } + +// accountIDValue is a convenience struct for using +// CTE's to provide accountIDs to select statuses of. +type accountIDValue struct { + AccountID string `bun:"type:CHAR(26)"` +} -- cgit v1.2.3