From 7d193de25fbccc00923d6d791d6d4e0d2d5d498e Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Wed, 1 Sep 2021 10:08:21 +0100 Subject: Improve GetRemoteStatus and db.GetStatus() logic (#174) * only fetch status parents / children if explicity requested when dereferencing Signed-off-by: kim (grufwub) * Remove recursive DB GetStatus logic, don't fetch parent unless requested Signed-off-by: kim (grufwub) * StatusCache copies status so there are no thread-safety issues with modified status objects Signed-off-by: kim (grufwub) * remove sqlite test files Signed-off-by: kim (grufwub) * fix bugs introduced by previous commit Signed-off-by: kim (grufwub) * fix not continue on error in loop Signed-off-by: kim (grufwub) * use our own RunInTx implementation (possible fix for nested tx error) Signed-off-by: kim (grufwub) * fix cast statement to work with SQLite Signed-off-by: kim (grufwub) * be less strict about valid status in cache Signed-off-by: kim (grufwub) * add cache=shared ALWAYS for SQLite db instances Signed-off-by: kim (grufwub) * Fix EnrichRemoteAccount when updating account fails Signed-off-by: kim (grufwub) * add nolint tag Signed-off-by: kim (grufwub) * ensure file: prefixes the filename in sqlite addr Signed-off-by: kim (grufwub) * add an account cache, add status author account from db Signed-off-by: kim (grufwub) * Fix incompatible SQLite query Signed-off-by: kim (grufwub) * *actually* use the new getAccount() function in accountsDB Signed-off-by: kim (grufwub) * update cache tests to use test suite Signed-off-by: kim (grufwub) * add RelationshipTestSuite, add tests for methods with changed SQL Signed-off-by: kim (grufwub) --- internal/db/bundb/status_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'internal/db/bundb/status_test.go') diff --git a/internal/db/bundb/status_test.go b/internal/db/bundb/status_test.go index 4f846441b..7acc86ff9 100644 --- a/internal/db/bundb/status_test.go +++ b/internal/db/bundb/status_test.go @@ -105,10 +105,9 @@ func (suite *StatusTestSuite) TestGetStatusWithMention() { suite.NotNil(status) suite.NotNil(status.Account) suite.NotNil(status.CreatedWithApplication) - suite.NotEmpty(status.Mentions) suite.NotEmpty(status.MentionIDs) - suite.NotNil(status.InReplyTo) - suite.NotNil(status.InReplyToAccount) + suite.NotEmpty(status.InReplyToID) + suite.NotEmpty(status.InReplyToAccountID) } func (suite *StatusTestSuite) TestGetStatusTwice() { -- cgit v1.2.3