From 84279f6a6a0201c90a6747fe8b82c38d5b4e49e2 Mon Sep 17 00:00:00 2001
From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com>
Date: Mon, 16 Sep 2024 16:46:09 +0000
Subject: [performance] cache more database calls, reduce required database
 calls overall (#3290)

* improvements to caching for lists and relationship to accounts / follows

* fix nil panic in AddToList()

* ensure list related caches are correctly invalidated

* ensure returned ID lists are ordered correctly

* bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded)

* remove zero checks in uncached key load functions (go-structr now handles this)

* fix issues after rebase on upstream/main

* update the expected return order of CSV exports (since list entries are now down by entry creation date)

* rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests

* use returning statements on delete to get cache invalidation info

* fixes to recent database delete changes

* fix broken list entries delete sql

* remove unused db function

* update remainder of delete functions to behave in similar way, some other small tweaks

* fix delete user sql, allow returning on err no entries

* uncomment + fix list database tests

* update remaining list tests

* update envparsing test

* add comments to each specific key being invalidated

* add more cache invalidation explanatory comments

* whoops; actually delete poll votes from database in the DeletePollByID() func

* remove added but-commented-out field

* improved comment regarding paging being disabled

* make cache invalidation comments match what's actually happening

* fix up delete query comments to match what is happening

* rename function to read a bit better

* don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call)

* update function name in test

* move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic()

* use the poll_id column in poll_votes for selecting votes in poll ID

* fix function name
---
 internal/db/bundb/poll_test.go | 36 ------------------------------------
 1 file changed, 36 deletions(-)

(limited to 'internal/db/bundb/poll_test.go')

diff --git a/internal/db/bundb/poll_test.go b/internal/db/bundb/poll_test.go
index 6bdbdb983..8af9295d9 100644
--- a/internal/db/bundb/poll_test.go
+++ b/internal/db/bundb/poll_test.go
@@ -26,7 +26,6 @@ import (
 
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/db"
-	"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
 	"github.com/superseriousbusiness/gotosocial/internal/id"
 	"github.com/superseriousbusiness/gotosocial/internal/util"
@@ -286,41 +285,6 @@ func (suite *PollTestSuite) TestDeletePoll() {
 	}
 }
 
-func (suite *PollTestSuite) TestDeletePollVotes() {
-	// Create a new context for this test.
-	ctx, cncl := context.WithCancel(context.Background())
-	defer cncl()
-
-	for _, poll := range suite.testPolls {
-		// Delete votes associated with poll from database.
-		err := suite.db.DeletePollVotes(ctx, poll.ID)
-		suite.NoError(err)
-
-		// Fetch latest version of poll from database.
-		poll, err = suite.db.GetPollByID(
-			gtscontext.SetBarebones(ctx),
-			poll.ID,
-		)
-		suite.NoError(err)
-
-		// Check that poll counts are all zero.
-		suite.Equal(*poll.Voters, 0)
-		suite.Equal(make([]int, len(poll.Options)), poll.Votes)
-	}
-}
-
-func (suite *PollTestSuite) TestDeletePollVotesNoPoll() {
-	// Create a new context for this test.
-	ctx, cncl := context.WithCancel(context.Background())
-	defer cncl()
-
-	// Try to delete votes of nonexistent poll.
-	nonPollID := "01HF6V4XWTSZWJ80JNPPDTD4DB"
-
-	err := suite.db.DeletePollVotes(ctx, nonPollID)
-	suite.NoError(err)
-}
-
 func (suite *PollTestSuite) TestDeletePollVotesBy() {
 	ctx, cncl := context.WithCancel(context.Background())
 	defer cncl()
-- 
cgit v1.2.3