From db803617db5621f33f6f1c16e05ae187f0e3ddbb Mon Sep 17 00:00:00 2001
From: tobi <31960611+tsmethurst@users.noreply.github.com>
Date: Fri, 14 Jun 2024 12:14:55 +0200
Subject: [bugfix] avoid v. long notification clear query (#3007)

---
 internal/db/bundb/notification_test.go | 30 +++++++++++++++++++++++++-----
 1 file changed, 25 insertions(+), 5 deletions(-)

(limited to 'internal/db/bundb/notification_test.go')

diff --git a/internal/db/bundb/notification_test.go b/internal/db/bundb/notification_test.go
index 9cc2e4743..984c0ef8d 100644
--- a/internal/db/bundb/notification_test.go
+++ b/internal/db/bundb/notification_test.go
@@ -73,7 +73,7 @@ func (suite *NotificationTestSuite) spamNotifs() {
 			Read:             util.Ptr(false),
 		}
 
-		if err := suite.db.Put(context.Background(), notif); err != nil {
+		if err := suite.db.PutNotification(context.Background(), notif); err != nil {
 			panic(err)
 		}
 	}
@@ -133,9 +133,8 @@ func (suite *NotificationTestSuite) TestGetAccountNotificationsWithoutSpam() {
 func (suite *NotificationTestSuite) TestDeleteNotificationsWithSpam() {
 	suite.spamNotifs()
 	testAccount := suite.testAccounts["local_account_1"]
-	err := suite.db.DeleteNotifications(context.Background(), nil, testAccount.ID, "")
-	suite.NoError(err)
 
+	// Test getting notifs first.
 	notifications, err := suite.db.GetAccountNotifications(
 		gtscontext.SetBarebones(context.Background()),
 		testAccount.ID,
@@ -145,8 +144,29 @@ func (suite *NotificationTestSuite) TestDeleteNotificationsWithSpam() {
 		20,
 		nil,
 	)
-	suite.NoError(err)
-	suite.Nil(notifications)
+	if err != nil {
+		suite.FailNow(err.Error())
+	}
+	suite.Len(notifications, 20)
+
+	// Now delete.
+	if err := suite.db.DeleteNotifications(context.Background(), nil, testAccount.ID, ""); err != nil {
+		suite.FailNow(err.Error())
+	}
+
+	// Now try getting again.
+	notifications, err = suite.db.GetAccountNotifications(
+		gtscontext.SetBarebones(context.Background()),
+		testAccount.ID,
+		id.Highest,
+		id.Lowest,
+		"",
+		20,
+		nil,
+	)
+	if err != nil {
+		suite.FailNow(err.Error())
+	}
 	suite.Empty(notifications)
 }
 
-- 
cgit v1.2.3