From f3c4ea01067830c02802bdf34f161aa77689a890 Mon Sep 17 00:00:00 2001 From: kim Date: Wed, 28 May 2025 11:36:14 +0200 Subject: [chore] thread_id migration tweaks (#4198) # Description - add a `migrations run` sub command to allow simply starting / stopping the db service, useful if you want to run *only* the migrations, both for testing or if you have a speedier box you want to run them on - tweaks to log messages - moved more stages outside of transactions, on sqlite if the transactions were getting too lengthy it could occasionally show an `sqlite: disk i/o error` ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4198 Co-authored-by: kim Co-committed-by: kim --- internal/db/bundb/migrations/util.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'internal/db/bundb/migrations/util.go') diff --git a/internal/db/bundb/migrations/util.go b/internal/db/bundb/migrations/util.go index 8da861df7..f20f23c3f 100644 --- a/internal/db/bundb/migrations/util.go +++ b/internal/db/bundb/migrations/util.go @@ -417,7 +417,7 @@ func getModelField(db bun.IDB, rtype reflect.Type, fieldName string) (*schema.Fi } // doesColumnExist safely checks whether given column exists on table, handling both SQLite and PostgreSQL appropriately. -func doesColumnExist(ctx context.Context, tx bun.Tx, table, col string) (bool, error) { +func doesColumnExist(ctx context.Context, tx bun.IDB, table, col string) (bool, error) { var n int var err error switch tx.Dialect().Name() { -- cgit v1.2.3