From 7b7659f1fa9d42410c4431caea2096c30169a718 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 2 Sep 2024 18:15:12 +0200 Subject: [chore/performance] Further reduce nil uncached queries (#3267) * [chore/performance] Further reduce nil uncached queries * more checks --- internal/db/bundb/conversation.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'internal/db/bundb/conversation.go') diff --git a/internal/db/bundb/conversation.go b/internal/db/bundb/conversation.go index 5756dac59..d8245dc58 100644 --- a/internal/db/bundb/conversation.go +++ b/internal/db/bundb/conversation.go @@ -313,7 +313,14 @@ func (c *conversationDB) DeleteConversationsByOwnerAccountID(ctx context.Context return gtserror.Newf("error deleting conversations for account %s: %w", accountID, err) } - // Delete any conversation-to-status links matching the deleted conversation IDs. + if len(deletedConversationIDs) == 0 { + // Nothing + // to delete. + return nil + } + + // Delete any conversation-to-status links + // matching the deleted conversation IDs. if _, err := tx.NewDelete(). Model((*gtsmodel.ConversationToStatus)(nil)). Where("? IN (?)", bun.Ident("conversation_id"), bun.In(deletedConversationIDs)). -- cgit v1.2.3