From 25a815a8a438b19a5eafe4243093803129d4c49a Mon Sep 17 00:00:00 2001
From: tobi <31960611+tsmethurst@users.noreply.github.com>
Date: Mon, 2 Sep 2024 14:00:17 +0200
Subject: [chore/performance] Avoid unnecessary "uncached" queries (#3265)

* [chore/performance] Avoid unnecessary "uncached" queries

* go fmt
---
 internal/db/bundb/application.go | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'internal/db/bundb/application.go')

diff --git a/internal/db/bundb/application.go b/internal/db/bundb/application.go
index fda0ba602..72c4ec206 100644
--- a/internal/db/bundb/application.go
+++ b/internal/db/bundb/application.go
@@ -147,8 +147,15 @@ func (a *applicationDB) GetAllTokens(ctx context.Context) ([]*gtsmodel.Token, er
 	tokens, err := a.state.Caches.DB.Token.LoadIDs("ID",
 		tokenIDs,
 		func(uncached []string) ([]*gtsmodel.Token, error) {
+			// Avoid querying
+			// if none uncached.
+			count := len(uncached)
+			if count == 0 {
+				return nil, nil
+			}
+
 			// Preallocate expected length of uncached tokens.
-			tokens := make([]*gtsmodel.Token, 0, len(uncached))
+			tokens := make([]*gtsmodel.Token, 0, count)
 
 			// Perform database query scanning
 			// the remaining (uncached) token IDs.
-- 
cgit v1.2.3