From 57fc267b5cc1d51026be054ddc5b1fcf1a62051a Mon Sep 17 00:00:00 2001 From: nopjmp Date: Tue, 6 May 2025 09:54:50 +0000 Subject: [feature] add ability to change s3 bucket lookup type (#4120) # Description This pull request implements the ability to specify the S3 bucket lookup type that is passed to the minio-go library. By default, minio-go uses a regex on the endpoint to see if it is a host that supports DNS access or not. Tigris and others are moving away from path style bucket access to DNS style bucket access using subdomains. This keeps the default as 'auto' to allow existing users to not need to modify their configurations. closes #3942 ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [ ] I/we have commented the added code, particularly in hard-to-understand areas. - [x] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Co-authored-by: tobi Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4120 Reviewed-by: kim Co-authored-by: nopjmp Co-committed-by: nopjmp --- internal/config/helpers.gen.go | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'internal/config/helpers.gen.go') diff --git a/internal/config/helpers.gen.go b/internal/config/helpers.gen.go index b039d26a5..2fa502084 100644 --- a/internal/config/helpers.gen.go +++ b/internal/config/helpers.gen.go @@ -1781,6 +1781,31 @@ func GetStorageS3RedirectURL() string { return global.GetStorageS3RedirectURL() // SetStorageS3RedirectURL safely sets the value for global configuration 'StorageS3RedirectURL' field func SetStorageS3RedirectURL(v string) { global.SetStorageS3RedirectURL(v) } +// GetStorageS3BucketLookup safely fetches the Configuration value for state's 'StorageS3BucketLookup' field +func (st *ConfigState) GetStorageS3BucketLookup() (v string) { + st.mutex.RLock() + v = st.config.StorageS3BucketLookup + st.mutex.RUnlock() + return +} + +// SetStorageS3BucketLookup safely sets the Configuration value for state's 'StorageS3BucketLookup' field +func (st *ConfigState) SetStorageS3BucketLookup(v string) { + st.mutex.Lock() + defer st.mutex.Unlock() + st.config.StorageS3BucketLookup = v + st.reloadToViper() +} + +// StorageS3BucketLookupFlag returns the flag name for the 'StorageS3BucketLookup' field +func StorageS3BucketLookupFlag() string { return "storage-s3-bucket-lookup" } + +// GetStorageS3BucketLookup safely fetches the value for global configuration 'StorageS3BucketLookup' field +func GetStorageS3BucketLookup() string { return global.GetStorageS3BucketLookup() } + +// SetStorageS3BucketLookup safely sets the value for global configuration 'StorageS3BucketLookup' field +func SetStorageS3BucketLookup(v string) { global.SetStorageS3BucketLookup(v) } + // GetStatusesMaxChars safely fetches the Configuration value for state's 'StatusesMaxChars' field func (st *ConfigState) GetStatusesMaxChars() (v int) { st.mutex.RLock() -- cgit v1.2.3