From de6e3e5f2a8ea639d76e310a11cb9bc093fef3a9 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 28 Mar 2023 14:03:14 +0100 Subject: [performance] refactoring + add fave / follow / request / visibility caching (#1607) * refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim Co-authored-by: tsmethurst --- internal/config/defaults.go | 82 +++++++++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 33 deletions(-) (limited to 'internal/config/defaults.go') diff --git a/internal/config/defaults.go b/internal/config/defaults.go index 17cc71086..999b81c65 100644 --- a/internal/config/defaults.go +++ b/internal/config/defaults.go @@ -51,7 +51,7 @@ var Defaults = Configuration{ DbSqliteJournalMode: "WAL", DbSqliteSynchronous: "NORMAL", DbSqliteCacheSize: 8 * bytesize.MiB, - DbSqliteBusyTimeout: time.Minute * 5, + DbSqliteBusyTimeout: time.Minute * 30, WebTemplateBaseDir: "./web/template/", WebAssetBaseDir: "./web/assets/", @@ -119,58 +119,74 @@ var Defaults = Configuration{ Cache: CacheConfiguration{ GTS: GTSCacheConfiguration{ - AccountMaxSize: 500, - AccountTTL: time.Minute * 5, - AccountSweepFreq: time.Second * 30, + AccountMaxSize: 2000, + AccountTTL: time.Minute * 30, + AccountSweepFreq: time.Minute, - BlockMaxSize: 100, - BlockTTL: time.Minute * 5, - BlockSweepFreq: time.Second * 30, + BlockMaxSize: 1000, + BlockTTL: time.Minute * 30, + BlockSweepFreq: time.Minute, - DomainBlockMaxSize: 1000, + DomainBlockMaxSize: 2000, DomainBlockTTL: time.Hour * 24, DomainBlockSweepFreq: time.Minute, - EmojiMaxSize: 500, - EmojiTTL: time.Minute * 5, - EmojiSweepFreq: time.Second * 30, + EmojiMaxSize: 2000, + EmojiTTL: time.Minute * 30, + EmojiSweepFreq: time.Minute, EmojiCategoryMaxSize: 100, - EmojiCategoryTTL: time.Minute * 5, - EmojiCategorySweepFreq: time.Second * 30, + EmojiCategoryTTL: time.Minute * 30, + EmojiCategorySweepFreq: time.Minute, - MediaMaxSize: 500, - MediaTTL: time.Minute * 5, - MediaSweepFreq: time.Second * 30, + FollowMaxSize: 2000, + FollowTTL: time.Minute * 30, + FollowSweepFreq: time.Minute, - MentionMaxSize: 500, - MentionTTL: time.Minute * 5, - MentionSweepFreq: time.Second * 30, + FollowRequestMaxSize: 2000, + FollowRequestTTL: time.Minute * 30, + FollowRequestSweepFreq: time.Minute, - NotificationMaxSize: 500, - NotificationTTL: time.Minute * 5, - NotificationSweepFreq: time.Second * 30, + MediaMaxSize: 1000, + MediaTTL: time.Minute * 30, + MediaSweepFreq: time.Minute, + + MentionMaxSize: 2000, + MentionTTL: time.Minute * 30, + MentionSweepFreq: time.Minute, + + NotificationMaxSize: 1000, + NotificationTTL: time.Minute * 30, + NotificationSweepFreq: time.Minute, ReportMaxSize: 100, - ReportTTL: time.Minute * 5, - ReportSweepFreq: time.Second * 30, + ReportTTL: time.Minute * 30, + ReportSweepFreq: time.Minute, - StatusMaxSize: 500, - StatusTTL: time.Minute * 5, - StatusSweepFreq: time.Second * 30, + StatusMaxSize: 2000, + StatusTTL: time.Minute * 30, + StatusSweepFreq: time.Minute, - TombstoneMaxSize: 100, - TombstoneTTL: time.Minute * 5, - TombstoneSweepFreq: time.Second * 30, + StatusFaveMaxSize: 2000, + StatusFaveTTL: time.Minute * 30, + StatusFaveSweepFreq: time.Minute, - UserMaxSize: 100, - UserTTL: time.Minute * 5, - UserSweepFreq: time.Second * 30, + TombstoneMaxSize: 500, + TombstoneTTL: time.Minute * 30, + TombstoneSweepFreq: time.Minute, + + UserMaxSize: 500, + UserTTL: time.Minute * 30, + UserSweepFreq: time.Minute, WebfingerMaxSize: 250, WebfingerTTL: time.Hour * 24, WebfingerSweepFreq: time.Minute * 15, }, + + VisibilityMaxSize: 2000, + VisibilityTTL: time.Minute * 30, + VisibilitySweepFreq: time.Minute, }, AdminMediaPruneDryRun: true, -- cgit v1.2.3