From fd670c6a279e2aa54822546536dbf88b45a93051 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 24 Feb 2025 11:17:18 +0100 Subject: [feature] Use ETag for robots.txt to prevent mishaps (#3829) * [feature] Use ETag for robots.txt to prevent mishaps * check incoming if-none-match header --- internal/api/robots/robots.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'internal/api/robots/robots.go') diff --git a/internal/api/robots/robots.go b/internal/api/robots/robots.go index 98db4682d..b72a01ed6 100644 --- a/internal/api/robots/robots.go +++ b/internal/api/robots/robots.go @@ -49,9 +49,29 @@ func (m *Module) Route(attachHandler func(method string, path string, f ...gin.H } func (m *Module) robotsGETHandler(c *gin.Context) { + const ETag = "\"" + apiutil.RobotsTxtETag + "\"" + c.Header("ETag", ETag) + + if c.Request.Header.Get("If-None-Match") == ETag { + // Cached. + c.AbortWithStatus(http.StatusNotModified) + return + } + + // Not cached, serve. c.String(http.StatusOK, apiutil.RobotsTxt) } func (m *Module) robotsGETHandlerDisallowNodeInfo(c *gin.Context) { + const ETag = "\"" + apiutil.RobotsTxtDisallowNodeInfoETag + "\"" + c.Header("ETag", ETag) + + if c.Request.Header.Get("If-None-Match") == ETag { + // Cached. + c.AbortWithStatus(http.StatusNotModified) + return + } + + // Not cached, serve. c.String(http.StatusOK, apiutil.RobotsTxtDisallowNodeInfo) } -- cgit v1.2.3