From f9cb086c53f06b6fd33f3c378ae1288751944eff Mon Sep 17 00:00:00 2001 From: tobi Date: Mon, 15 Sep 2025 13:26:50 +0200 Subject: [bugfix] Parse `scheduled_at` as ISO8601 with offset if RFC3339 parse fails (#4431) # Description > If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements. > > If this is a documentation change, please briefly describe what you've changed and why. Closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4409 by reattempting `scheduled_at` parsing using ISO8601 offset. ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [x] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4431 Co-authored-by: tobi Co-committed-by: tobi --- internal/api/model/status.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'internal/api/model') diff --git a/internal/api/model/status.go b/internal/api/model/status.go index 3edb4be5f..3ce5913bd 100644 --- a/internal/api/model/status.go +++ b/internal/api/model/status.go @@ -248,14 +248,18 @@ type StatusCreateRequest struct { // Deprecated: Only used if LocalOnly is not set. Federated *bool `form:"federated" json:"federated"` - // ISO 8601 Datetime at which to schedule a status. + // ISO8601 datetime string at which to schedule a status. // - // Providing this parameter with a *future* time will cause ScheduledStatus to be returned instead of Status. - // Must be at least 5 minutes in the future. + // Providing this parameter with a *future* time will cause ScheduledStatus + // to be returned instead of Status (must be at least 5 minutes in the future). // // Providing this parameter with a *past* time will cause the status to be backdated, // and will not push it to the user's followers. This is intended for importing old statuses. - ScheduledAt *time.Time `form:"scheduled_at" json:"scheduled_at"` + ScheduledAtRaw string `form:"scheduled_at" json:"scheduled_at"` + + // ScheduledAtParsed is the parsed version + // of scheduled_at, if scheduled_at was set. + ScheduledAt *time.Time `form:"-" json:"-"` // ISO 639 language code for this status. Language string `form:"language" json:"language"` -- cgit v1.3