From d4cddf460a5145965b398e167f3cea24b5e3e436 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 16 Jan 2023 16:19:17 +0100 Subject: [bugfix] Parse video metadata more accurately; allow Range in fileserver (#1342) * don't serve unused fields for video attachments * parse video bitrate + duration more accurately * use ServeContent where appropriate to respect Range * abstract temp file seeker into its own function --- internal/api/client/media/mediacreate_test.go | 4 ++-- internal/api/client/media/mediaupdate_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'internal/api/client') diff --git a/internal/api/client/media/mediacreate_test.go b/internal/api/client/media/mediacreate_test.go index 6ac63a356..320636721 100644 --- a/internal/api/client/media/mediacreate_test.go +++ b/internal/api/client/media/mediacreate_test.go @@ -201,7 +201,7 @@ func (suite *MediaCreateTestSuite) TestMediaCreateSuccessful() { Size: "512x288", Aspect: 1.7777778, }, - Focus: apimodel.MediaFocus{ + Focus: &apimodel.MediaFocus{ X: -0.5, Y: 0.5, }, @@ -290,7 +290,7 @@ func (suite *MediaCreateTestSuite) TestMediaCreateSuccessfulV2() { Size: "512x288", Aspect: 1.7777778, }, - Focus: apimodel.MediaFocus{ + Focus: &apimodel.MediaFocus{ X: -0.5, Y: 0.5, }, diff --git a/internal/api/client/media/mediaupdate_test.go b/internal/api/client/media/mediaupdate_test.go index 3b1d94368..1425d80ef 100644 --- a/internal/api/client/media/mediaupdate_test.go +++ b/internal/api/client/media/mediaupdate_test.go @@ -172,7 +172,7 @@ func (suite *MediaUpdateTestSuite) TestUpdateImage() { suite.EqualValues(apimodel.MediaMeta{ Original: apimodel.MediaDimensions{Width: 800, Height: 450, FrameRate: "", Duration: 0, Bitrate: 0, Size: "800x450", Aspect: 1.7777778}, Small: apimodel.MediaDimensions{Width: 256, Height: 144, FrameRate: "", Duration: 0, Bitrate: 0, Size: "256x144", Aspect: 1.7777778}, - Focus: apimodel.MediaFocus{X: -0.1, Y: 0.3}, + Focus: &apimodel.MediaFocus{X: -0.1, Y: 0.3}, }, attachmentReply.Meta) suite.Equal(toUpdate.Blurhash, attachmentReply.Blurhash) suite.Equal(toUpdate.ID, attachmentReply.ID) -- cgit v1.2.3