From 3f1c3c0dacafce8a4421e5d2570adf2084f29756 Mon Sep 17 00:00:00 2001 From: nicole mikołajczyk Date: Mon, 9 Jun 2025 16:26:49 +0200 Subject: [bugfix] return 422 for invalid status visibility (#4252) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: nicole mikołajczyk # Description closes #4247 ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [ ] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4252 Co-authored-by: nicole mikołajczyk Co-committed-by: nicole mikołajczyk --- internal/api/client/statuses/statuscreate_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'internal/api/client/statuses/statuscreate_test.go') diff --git a/internal/api/client/statuses/statuscreate_test.go b/internal/api/client/statuses/statuscreate_test.go index 548eced29..090dae593 100644 --- a/internal/api/client/statuses/statuscreate_test.go +++ b/internal/api/client/statuses/statuscreate_test.go @@ -446,7 +446,7 @@ func (suite *StatusCreateTestSuite) TestPostNewStatusIntPolicyJSON() { func (suite *StatusCreateTestSuite) TestPostNewStatusMessedUpIntPolicy() { out, recorder := suite.postStatus(nil, `{ "status": "this is a brand new status! #helloworld", - "visibility": "followers_only", + "visibility": "private", "interaction_policy": { "can_reply": { "always": [ @@ -463,7 +463,7 @@ func (suite *StatusCreateTestSuite) TestPostNewStatusMessedUpIntPolicy() { // We should have a helpful error // message telling us how we screwed up. suite.Equal(`{ - "error": "Bad Request: error converting followers_only.can_reply.always: policyURI public is not feasible for visibility followers_only" + "error": "Bad Request: error converting private.can_reply.always: policyURI public is not feasible for visibility private" }`, out) } -- cgit v1.2.3