From f8630348b4c14215d87921962a2acbe8d3b6c981 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 22 Nov 2021 08:46:19 +0100 Subject: Enable stricter linting with golangci-lint (#316) * update golangci-lint * add golangci config file w/ more linters * correct issues flagged by stricter linters * add more generous timeout for golangci-lint * add some style + formatting guidelines * move timeout to config file * go fmt --- internal/api/client/app/appcreate.go | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) (limited to 'internal/api/client/app/appcreate.go') diff --git a/internal/api/client/app/appcreate.go b/internal/api/client/app/appcreate.go index 0c9407ae1..c23a838f4 100644 --- a/internal/api/client/app/appcreate.go +++ b/internal/api/client/app/appcreate.go @@ -20,14 +20,22 @@ package app import ( "fmt" - "github.com/sirupsen/logrus" "net/http" + "github.com/sirupsen/logrus" + "github.com/gin-gonic/gin" "github.com/superseriousbusiness/gotosocial/internal/api/model" "github.com/superseriousbusiness/gotosocial/internal/oauth" ) +const ( + // permitted length for most fields + formFieldLen = 64 + // redirect can be a bit bigger because we probably need to encode data in the redirect uri + formRedirectLen = 512 +) + // AppsPOSTHandler swagger:operation POST /api/v1/apps appCreate // // Register a new application on this instance. @@ -79,11 +87,6 @@ func (m *Module) AppsPOSTHandler(c *gin.Context) { return } - // permitted length for most fields - formFieldLen := 64 - // redirect can be a bit bigger because we probably need to encode data in the redirect uri - formRedirectLen := 512 - // check lengths of fields before proceeding so the user can't spam huge entries into the database if len(form.ClientName) > formFieldLen { c.JSON(http.StatusBadRequest, gin.H{"error": fmt.Sprintf("client_name must be less than %d bytes", formFieldLen)}) -- cgit v1.2.3