diff options
Diffstat (limited to 'internal/federation')
| -rw-r--r-- | internal/federation/dereferencing/status.go | 2 | ||||
| -rw-r--r-- | internal/federation/federatingdb/accept.go | 10 | ||||
| -rw-r--r-- | internal/federation/federatingdb/create.go | 2 | ||||
| -rw-r--r-- | internal/federation/federatingdb/followers.go | 2 | ||||
| -rw-r--r-- | internal/federation/federatingdb/following.go | 2 | ||||
| -rw-r--r-- | internal/federation/federatingdb/inbox.go | 2 | ||||
| -rw-r--r-- | internal/federation/federatingdb/reject.go | 12 | ||||
| -rw-r--r-- | internal/federation/federatingdb/undo.go | 5 | ||||
| -rw-r--r-- | internal/federation/federatingdb/util.go | 10 | ||||
| -rw-r--r-- | internal/federation/federatingprotocol.go | 6 | 
10 files changed, 24 insertions, 29 deletions
| diff --git a/internal/federation/dereferencing/status.go b/internal/federation/dereferencing/status.go index 55a41ff09..8e202d585 100644 --- a/internal/federation/dereferencing/status.go +++ b/internal/federation/dereferencing/status.go @@ -383,7 +383,7 @@ func (d *deref) populateStatusMentions(ctx context.Context, status *gtsmodel.Sta  			TargetAccountURL: targetAccount.URL,  		} -		if err := d.db.Put(ctx, newMention); err != nil { +		if err := d.db.PutMention(ctx, newMention); err != nil {  			return fmt.Errorf("populateStatusMentions: error creating mention: %s", err)  		} diff --git a/internal/federation/federatingdb/accept.go b/internal/federation/federatingdb/accept.go index 8f0e40694..1c39bc134 100644 --- a/internal/federation/federatingdb/accept.go +++ b/internal/federation/federatingdb/accept.go @@ -25,8 +25,6 @@ import (  	"codeberg.org/gruf/go-logger/v2/level"  	"github.com/superseriousbusiness/activity/streams/vocab"  	"github.com/superseriousbusiness/gotosocial/internal/ap" -	"github.com/superseriousbusiness/gotosocial/internal/db" -	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"  	"github.com/superseriousbusiness/gotosocial/internal/log"  	"github.com/superseriousbusiness/gotosocial/internal/messages"  	"github.com/superseriousbusiness/gotosocial/internal/uris" @@ -63,16 +61,16 @@ func (f *federatingDB) Accept(ctx context.Context, accept vocab.ActivityStreamsA  			acceptedObjectIRI := iter.GetIRI()  			if uris.IsFollowPath(acceptedObjectIRI) {  				// ACCEPT FOLLOW -				gtsFollowRequest := >smodel.FollowRequest{} -				if err := f.state.DB.GetWhere(ctx, []db.Where{{Key: "uri", Value: acceptedObjectIRI.String()}}, gtsFollowRequest); err != nil { +				followReq, err := f.state.DB.GetFollowRequestByURI(ctx, acceptedObjectIRI.String()) +				if err != nil {  					return fmt.Errorf("ACCEPT: couldn't get follow request with id %s from the database: %s", acceptedObjectIRI.String(), err)  				}  				// make sure the addressee of the original follow is the same as whatever inbox this landed in -				if gtsFollowRequest.AccountID != receivingAccount.ID { +				if followReq.AccountID != receivingAccount.ID {  					return errors.New("ACCEPT: follow object account and inbox account were not the same")  				} -				follow, err := f.state.DB.AcceptFollowRequest(ctx, gtsFollowRequest.AccountID, gtsFollowRequest.TargetAccountID) +				follow, err := f.state.DB.AcceptFollowRequest(ctx, followReq.AccountID, followReq.TargetAccountID)  				if err != nil {  					return err  				} diff --git a/internal/federation/federatingdb/create.go b/internal/federation/federatingdb/create.go index a82cd5cdf..166ea34a9 100644 --- a/internal/federation/federatingdb/create.go +++ b/internal/federation/federatingdb/create.go @@ -262,7 +262,7 @@ func (f *federatingDB) activityFollow(ctx context.Context, asType vocab.Type, re  	followRequest.ID = id.NewULID() -	if err := f.state.DB.Put(ctx, followRequest); err != nil { +	if err := f.state.DB.PutFollowRequest(ctx, followRequest); err != nil {  		return fmt.Errorf("activityFollow: database error inserting follow request: %s", err)  	} diff --git a/internal/federation/federatingdb/followers.go b/internal/federation/federatingdb/followers.go index d829a304c..4ca2e2683 100644 --- a/internal/federation/federatingdb/followers.go +++ b/internal/federation/federatingdb/followers.go @@ -38,7 +38,7 @@ func (f *federatingDB) Followers(ctx context.Context, actorIRI *url.URL) (follow  		return nil, err  	} -	follows, err := f.state.DB.GetFollows(ctx, "", acct.ID) +	follows, err := f.state.DB.GetAccountFollowers(ctx, acct.ID)  	if err != nil {  		return nil, fmt.Errorf("Followers: db error getting followers for account id %s: %s", acct.ID, err)  	} diff --git a/internal/federation/federatingdb/following.go b/internal/federation/federatingdb/following.go index 7b0db5660..391a2f810 100644 --- a/internal/federation/federatingdb/following.go +++ b/internal/federation/federatingdb/following.go @@ -38,7 +38,7 @@ func (f *federatingDB) Following(ctx context.Context, actorIRI *url.URL) (follow  		return nil, err  	} -	follows, err := f.state.DB.GetFollows(ctx, acct.ID, "") +	follows, err := f.state.DB.GetAccountFollows(ctx, acct.ID)  	if err != nil {  		return nil, fmt.Errorf("Following: db error getting following for account id %s: %w", acct.ID, err)  	} diff --git a/internal/federation/federatingdb/inbox.go b/internal/federation/federatingdb/inbox.go index 954a192e4..18974ba79 100644 --- a/internal/federation/federatingdb/inbox.go +++ b/internal/federation/federatingdb/inbox.go @@ -89,7 +89,7 @@ func (f *federatingDB) InboxesForIRI(c context.Context, iri *url.URL) (inboxIRIs  			return nil, fmt.Errorf("couldn't find local account with username %s: %s", localAccountUsername, err)  		} -		follows, err := f.state.DB.GetFollows(c, "", account.ID) +		follows, err := f.state.DB.GetAccountFollowers(c, account.ID)  		if err != nil {  			return nil, fmt.Errorf("couldn't get followers of local account %s: %s", localAccountUsername, err)  		} diff --git a/internal/federation/federatingdb/reject.go b/internal/federation/federatingdb/reject.go index e19224283..ceaee83ef 100644 --- a/internal/federation/federatingdb/reject.go +++ b/internal/federation/federatingdb/reject.go @@ -25,8 +25,6 @@ import (  	"codeberg.org/gruf/go-logger/v2/level"  	"github.com/superseriousbusiness/activity/streams/vocab"  	"github.com/superseriousbusiness/gotosocial/internal/ap" -	"github.com/superseriousbusiness/gotosocial/internal/db" -	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"  	"github.com/superseriousbusiness/gotosocial/internal/log"  	"github.com/superseriousbusiness/gotosocial/internal/uris"  ) @@ -62,17 +60,17 @@ func (f *federatingDB) Reject(ctx context.Context, reject vocab.ActivityStreamsR  			rejectedObjectIRI := iter.GetIRI()  			if uris.IsFollowPath(rejectedObjectIRI) {  				// REJECT FOLLOW -				gtsFollowRequest := >smodel.FollowRequest{} -				if err := f.state.DB.GetWhere(ctx, []db.Where{{Key: "uri", Value: rejectedObjectIRI.String()}}, gtsFollowRequest); err != nil { +				followReq, err := f.state.DB.GetFollowRequestByURI(ctx, rejectedObjectIRI.String()) +				if err != nil {  					return fmt.Errorf("Reject: couldn't get follow request with id %s from the database: %s", rejectedObjectIRI.String(), err)  				}  				// make sure the addressee of the original follow is the same as whatever inbox this landed in -				if gtsFollowRequest.AccountID != receivingAccount.ID { +				if followReq.AccountID != receivingAccount.ID {  					return errors.New("Reject: follow object account and inbox account were not the same")  				} -				if _, err := f.state.DB.RejectFollowRequest(ctx, gtsFollowRequest.AccountID, gtsFollowRequest.TargetAccountID); err != nil { +				if err := f.state.DB.RejectFollowRequest(ctx, followReq.AccountID, followReq.TargetAccountID); err != nil {  					return err  				} @@ -101,7 +99,7 @@ func (f *federatingDB) Reject(ctx context.Context, reject vocab.ActivityStreamsR  			if gtsFollow.AccountID != receivingAccount.ID {  				return errors.New("Reject: follow object account and inbox account were not the same")  			} -			if _, err := f.state.DB.RejectFollowRequest(ctx, gtsFollow.AccountID, gtsFollow.TargetAccountID); err != nil { +			if err := f.state.DB.RejectFollowRequest(ctx, gtsFollow.AccountID, gtsFollow.TargetAccountID); err != nil {  				return err  			} diff --git a/internal/federation/federatingdb/undo.go b/internal/federation/federatingdb/undo.go index 5e75b22f7..517aa9cc6 100644 --- a/internal/federation/federatingdb/undo.go +++ b/internal/federation/federatingdb/undo.go @@ -26,7 +26,6 @@ import (  	"github.com/superseriousbusiness/activity/streams/vocab"  	"github.com/superseriousbusiness/gotosocial/internal/ap"  	"github.com/superseriousbusiness/gotosocial/internal/db" -	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"  	"github.com/superseriousbusiness/gotosocial/internal/log"  ) @@ -80,11 +79,11 @@ func (f *federatingDB) Undo(ctx context.Context, undo vocab.ActivityStreamsUndo)  				return errors.New("UNDO: follow object account and inbox account were not the same")  			}  			// delete any existing FOLLOW -			if err := f.state.DB.DeleteWhere(ctx, []db.Where{{Key: "uri", Value: gtsFollow.URI}}, >smodel.Follow{}); err != nil { +			if err := f.state.DB.DeleteFollowByURI(ctx, gtsFollow.URI); err != nil && !errors.Is(err, db.ErrNoEntries) {  				return fmt.Errorf("UNDO: db error removing follow: %s", err)  			}  			// delete any existing FOLLOW REQUEST -			if err := f.state.DB.DeleteWhere(ctx, []db.Where{{Key: "uri", Value: gtsFollow.URI}}, >smodel.FollowRequest{}); err != nil { +			if err := f.state.DB.DeleteFollowRequestByURI(ctx, gtsFollow.URI); err != nil && !errors.Is(err, db.ErrNoEntries) {  				return fmt.Errorf("UNDO: db error removing follow request: %s", err)  			}  			l.Debug("follow undone") diff --git a/internal/federation/federatingdb/util.go b/internal/federation/federatingdb/util.go index df446a5f3..8ad209f5e 100644 --- a/internal/federation/federatingdb/util.go +++ b/internal/federation/federatingdb/util.go @@ -231,7 +231,7 @@ func (f *federatingDB) ActorForInbox(ctx context.Context, inboxIRI *url.URL) (ac  // getAccountForIRI returns the account that corresponds to or owns the given IRI.  func (f *federatingDB) getAccountForIRI(ctx context.Context, iri *url.URL) (*gtsmodel.Account, error) {  	var ( -		acct = >smodel.Account{} +		acct *gtsmodel.Account  		err  error  	) @@ -245,7 +245,7 @@ func (f *federatingDB) getAccountForIRI(ctx context.Context, iri *url.URL) (*gts  		}  		return acct, nil  	case uris.IsInboxPath(iri): -		if err = f.state.DB.GetWhere(ctx, []db.Where{{Key: "inbox_uri", Value: iri.String()}}, acct); err != nil { +		if acct, err = f.state.DB.GetAccountByInboxURI(ctx, iri.String()); err != nil {  			if err == db.ErrNoEntries {  				return nil, fmt.Errorf("no actor found that corresponds to inbox %s", iri.String())  			} @@ -253,7 +253,7 @@ func (f *federatingDB) getAccountForIRI(ctx context.Context, iri *url.URL) (*gts  		}  		return acct, nil  	case uris.IsOutboxPath(iri): -		if err = f.state.DB.GetWhere(ctx, []db.Where{{Key: "outbox_uri", Value: iri.String()}}, acct); err != nil { +		if acct, err = f.state.DB.GetAccountByOutboxURI(ctx, iri.String()); err != nil {  			if err == db.ErrNoEntries {  				return nil, fmt.Errorf("no actor found that corresponds to outbox %s", iri.String())  			} @@ -261,7 +261,7 @@ func (f *federatingDB) getAccountForIRI(ctx context.Context, iri *url.URL) (*gts  		}  		return acct, nil  	case uris.IsFollowersPath(iri): -		if err = f.state.DB.GetWhere(ctx, []db.Where{{Key: "followers_uri", Value: iri.String()}}, acct); err != nil { +		if acct, err = f.state.DB.GetAccountByFollowersURI(ctx, iri.String()); err != nil {  			if err == db.ErrNoEntries {  				return nil, fmt.Errorf("no actor found that corresponds to followers_uri %s", iri.String())  			} @@ -269,7 +269,7 @@ func (f *federatingDB) getAccountForIRI(ctx context.Context, iri *url.URL) (*gts  		}  		return acct, nil  	case uris.IsFollowingPath(iri): -		if err = f.state.DB.GetWhere(ctx, []db.Where{{Key: "following_uri", Value: iri.String()}}, acct); err != nil { +		if acct, err = f.state.DB.GetAccountByFollowingURI(ctx, iri.String()); err != nil {  			if err == db.ErrNoEntries {  				return nil, fmt.Errorf("no actor found that corresponds to following_uri %s", iri.String())  			} diff --git a/internal/federation/federatingprotocol.go b/internal/federation/federatingprotocol.go index 37d43276b..ed0a216fe 100644 --- a/internal/federation/federatingprotocol.go +++ b/internal/federation/federatingprotocol.go @@ -283,7 +283,7 @@ func (f *federator) Blocked(ctx context.Context, actorIRIs []*url.URL) (bool, er  		return false, errors.New("requesting account not set on request context, so couldn't determine blocks")  	}  	// the receiver shouldn't block the sender -	blocked, err = f.db.IsBlocked(ctx, receivingAccount.ID, requestingAccount.ID, false) +	blocked, err = f.db.IsBlocked(ctx, receivingAccount.ID, requestingAccount.ID)  	if err != nil {  		return false, fmt.Errorf("error checking user-level blocks: %s", err)  	} @@ -309,7 +309,7 @@ func (f *federator) Blocked(ctx context.Context, actorIRIs []*url.URL) (bool, er  	for _, involvedAccountID := range deduped {  		// the involved account shouldn't block whoever is making this request -		blocked, err = f.db.IsBlocked(ctx, involvedAccountID, requestingAccount.ID, false) +		blocked, err = f.db.IsBlocked(ctx, involvedAccountID, requestingAccount.ID)  		if err != nil {  			return false, fmt.Errorf("error checking user-level otherInvolvedIRI blocks: %s", err)  		} @@ -318,7 +318,7 @@ func (f *federator) Blocked(ctx context.Context, actorIRIs []*url.URL) (bool, er  		}  		// whoever is receiving this request shouldn't block the involved account -		blocked, err = f.db.IsBlocked(ctx, receivingAccount.ID, involvedAccountID, false) +		blocked, err = f.db.IsBlocked(ctx, receivingAccount.ID, involvedAccountID)  		if err != nil {  			return false, fmt.Errorf("error checking user-level otherInvolvedIRI blocks: %s", err)  		} | 
