diff options
Diffstat (limited to 'internal/api')
| -rw-r--r-- | internal/api/client/auth/authorize.go | 8 | ||||
| -rw-r--r-- | internal/api/client/auth/signin.go | 11 | ||||
| -rw-r--r-- | internal/api/client/user/passwordchange.go | 2 | ||||
| -rw-r--r-- | internal/api/client/user/passwordchange_test.go | 6 | 
4 files changed, 22 insertions, 5 deletions
diff --git a/internal/api/client/auth/authorize.go b/internal/api/client/auth/authorize.go index 1a594a319..67325a81d 100644 --- a/internal/api/client/auth/authorize.go +++ b/internal/api/client/auth/authorize.go @@ -29,6 +29,7 @@ import (  	"github.com/google/uuid"  	"github.com/superseriousbusiness/gotosocial/internal/api"  	"github.com/superseriousbusiness/gotosocial/internal/api/model" +	"github.com/superseriousbusiness/gotosocial/internal/config"  	"github.com/superseriousbusiness/gotosocial/internal/db"  	"github.com/superseriousbusiness/gotosocial/internal/gtserror"  	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel" @@ -142,6 +143,12 @@ func (m *Module) AuthorizeGETHandler(c *gin.Context) {  		return  	} +	instance, errWithCode := m.processor.InstanceGet(c.Request.Context(), config.GetHost()) +	if errWithCode != nil { +		api.ErrorHandler(c, errWithCode, m.processor.InstanceGet) +		return +	} +  	// the authorize template will display a form to the user where they can get some information  	// about the app that's trying to authorize, and the scope of the request.  	// They can then approve it if it looks OK to them, which will POST to the AuthorizePOSTHandler @@ -151,6 +158,7 @@ func (m *Module) AuthorizeGETHandler(c *gin.Context) {  		"redirect":   redirect,  		"scope":      scope,  		"user":       acct.Username, +		"instance":   instance,  	})  } diff --git a/internal/api/client/auth/signin.go b/internal/api/client/auth/signin.go index f9541d4c5..58f3fad7e 100644 --- a/internal/api/client/auth/signin.go +++ b/internal/api/client/auth/signin.go @@ -27,6 +27,7 @@ import (  	"github.com/gin-contrib/sessions"  	"github.com/gin-gonic/gin"  	"github.com/superseriousbusiness/gotosocial/internal/api" +	"github.com/superseriousbusiness/gotosocial/internal/config"  	"github.com/superseriousbusiness/gotosocial/internal/db"  	"github.com/superseriousbusiness/gotosocial/internal/gtserror"  	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel" @@ -50,8 +51,16 @@ func (m *Module) SignInGETHandler(c *gin.Context) {  	}  	if m.idp == nil { +		instance, errWithCode := m.processor.InstanceGet(c.Request.Context(), config.GetHost()) +		if errWithCode != nil { +			api.ErrorHandler(c, errWithCode, m.processor.InstanceGet) +			return +		} +  		// no idp provider, use our own funky little sign in page -		c.HTML(http.StatusOK, "sign-in.tmpl", gin.H{}) +		c.HTML(http.StatusOK, "sign-in.tmpl", gin.H{ +			"instance": instance, +		})  		return  	} diff --git a/internal/api/client/user/passwordchange.go b/internal/api/client/user/passwordchange.go index 7676f5b85..2b40a345e 100644 --- a/internal/api/client/user/passwordchange.go +++ b/internal/api/client/user/passwordchange.go @@ -100,5 +100,5 @@ func (m *Module) PasswordChangePOSTHandler(c *gin.Context) {  		return  	} -	c.Status(http.StatusOK) +	c.JSON(http.StatusOK, gin.H{"status": "OK"})  } diff --git a/internal/api/client/user/passwordchange_test.go b/internal/api/client/user/passwordchange_test.go index 31b59b2ce..3c0fd7b30 100644 --- a/internal/api/client/user/passwordchange_test.go +++ b/internal/api/client/user/passwordchange_test.go @@ -119,13 +119,13 @@ func (suite *PasswordChangeTestSuite) TestPasswordIncorrectOldPassword() {  	suite.userModule.PasswordChangePOSTHandler(ctx)  	// check response -	suite.EqualValues(http.StatusBadRequest, recorder.Code) +	suite.EqualValues(http.StatusUnauthorized, recorder.Code)  	result := recorder.Result()  	defer result.Body.Close()  	b, err := ioutil.ReadAll(result.Body)  	suite.NoError(err) -	suite.Equal(`{"error":"Bad Request: old password did not match"}`, string(b)) +	suite.Equal(`{"error":"Unauthorized: old password was incorrect"}`, string(b))  }  func (suite *PasswordChangeTestSuite) TestPasswordWeakNewPassword() { @@ -153,7 +153,7 @@ func (suite *PasswordChangeTestSuite) TestPasswordWeakNewPassword() {  	defer result.Body.Close()  	b, err := ioutil.ReadAll(result.Body)  	suite.NoError(err) -	suite.Equal(`{"error":"Bad Request: password is 94% strength, try including more special characters, using uppercase letters, using numbers or using a longer password"}`, string(b)) +	suite.Equal(`{"error":"Bad Request: password is only 94% strength, try including more special characters, using uppercase letters, using numbers or using a longer password"}`, string(b))  }  func TestPasswordChangeTestSuite(t *testing.T) {  | 
