diff options
Diffstat (limited to 'internal/api/s2s/user')
| -rw-r--r-- | internal/api/s2s/user/common.go | 59 | ||||
| -rw-r--r-- | internal/api/s2s/user/followers.go | 24 | ||||
| -rw-r--r-- | internal/api/s2s/user/following.go | 24 | ||||
| -rw-r--r-- | internal/api/s2s/user/inboxpost.go | 9 | ||||
| -rw-r--r-- | internal/api/s2s/user/publickeyget.go | 24 | ||||
| -rw-r--r-- | internal/api/s2s/user/repliesget.go | 24 | ||||
| -rw-r--r-- | internal/api/s2s/user/statusget.go | 24 | ||||
| -rw-r--r-- | internal/api/s2s/user/user.go | 7 | ||||
| -rw-r--r-- | internal/api/s2s/user/userget.go | 24 | 
9 files changed, 108 insertions, 111 deletions
| diff --git a/internal/api/s2s/user/common.go b/internal/api/s2s/user/common.go new file mode 100644 index 000000000..8a3846901 --- /dev/null +++ b/internal/api/s2s/user/common.go @@ -0,0 +1,59 @@ +/* +   GoToSocial +   Copyright (C) 2021 GoToSocial Authors admin@gotosocial.org + +   This program is free software: you can redistribute it and/or modify +   it under the terms of the GNU Affero General Public License as published by +   the Free Software Foundation, either version 3 of the License, or +   (at your option) any later version. + +   This program is distributed in the hope that it will be useful, +   but WITHOUT ANY WARRANTY; without even the implied warranty of +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the +   GNU Affero General Public License for more details. + +   You should have received a copy of the GNU Affero General Public License +   along with this program.  If not, see <http://www.gnu.org/licenses/>. +*/ + +package user + +import ( +	"context" +	"fmt" + +	"github.com/gin-gonic/gin" +	"github.com/superseriousbusiness/gotosocial/internal/util" +) + +// ActivityPubAcceptHeaders represents the Accept headers mentioned here: +// https://www.w3.org/TR/activitypub/#retrieving-objects +var ActivityPubAcceptHeaders = []string{ +	`application/activity+json`, +	`application/ld+json; profile="https://www.w3.org/ns/activitystreams"`, +} + +// populateContext transfers the signature verifier and signature from the gin context to the request context +func populateContext(c *gin.Context) context.Context { +	ctx := c.Request.Context() + +	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) +	if signed { +		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) +	} + +	signature, signed := c.Get(string(util.APRequestingPublicKeySignature)) +	if signed { +		ctx = context.WithValue(ctx, util.APRequestingPublicKeySignature, signature) +	} + +	return ctx +} + +func negotiateFormat(c *gin.Context) (string, error) { +	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) +	if format == "" { +		return "", fmt.Errorf("no format can be offered for Accept headers %s", c.Request.Header.Get("Accept")) +	} +	return format, nil +} diff --git a/internal/api/s2s/user/followers.go b/internal/api/s2s/user/followers.go index f9aec7ffb..c85c24c95 100644 --- a/internal/api/s2s/user/followers.go +++ b/internal/api/s2s/user/followers.go @@ -19,14 +19,12 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // FollowersGETHandler returns a collection of URIs for followers of the target user, formatted so that other AP servers can understand it. @@ -42,25 +40,19 @@ func (m *Module) FollowersGETHandler(c *gin.Context) {  		return  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	followers, err := m.processor.GetFediFollowers(ctx, requestedUsername, c.Request.URL) // GetFediUser handles auth as well -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	followers, errWithCode := m.processor.GetFediFollowers(ctx, requestedUsername, c.Request.URL) +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} diff --git a/internal/api/s2s/user/following.go b/internal/api/s2s/user/following.go index 4c010dbe0..7c5b1bbf7 100644 --- a/internal/api/s2s/user/following.go +++ b/internal/api/s2s/user/following.go @@ -19,14 +19,12 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // FollowingGETHandler returns a collection of URIs for accounts that the target user follows, formatted so that other AP servers can understand it. @@ -42,25 +40,19 @@ func (m *Module) FollowingGETHandler(c *gin.Context) {  		return  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	following, err := m.processor.GetFediFollowing(ctx, requestedUsername, c.Request.URL) // handles auth as well -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	following, errWithCode := m.processor.GetFediFollowing(ctx, requestedUsername, c.Request.URL) +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} diff --git a/internal/api/s2s/user/inboxpost.go b/internal/api/s2s/user/inboxpost.go index 98442af13..8e44454d7 100644 --- a/internal/api/s2s/user/inboxpost.go +++ b/internal/api/s2s/user/inboxpost.go @@ -19,13 +19,11 @@  package user  import ( -	"context"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus"  	"github.com/superseriousbusiness/gotosocial/internal/gtserror" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // InboxPOSTHandler deals with incoming POST requests to an actor's inbox. @@ -42,12 +40,7 @@ func (m *Module) InboxPOSTHandler(c *gin.Context) {  		return  	} -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c)  	posted, err := m.processor.InboxPost(ctx, c.Writer, c.Request)  	if err != nil { diff --git a/internal/api/s2s/user/publickeyget.go b/internal/api/s2s/user/publickeyget.go index 2cbe564df..f5fe79441 100644 --- a/internal/api/s2s/user/publickeyget.go +++ b/internal/api/s2s/user/publickeyget.go @@ -1,14 +1,12 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // PublicKeyGETHandler should be served at eg https://example.org/users/:username/main-key. @@ -28,25 +26,19 @@ func (m *Module) PublicKeyGETHandler(c *gin.Context) {  		return  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	user, err := m.processor.GetFediUser(ctx, requestedUsername, c.Request.URL) // GetFediUser handles auth as well -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	user, errWithCode := m.processor.GetFediUser(ctx, requestedUsername, c.Request.URL) +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} diff --git a/internal/api/s2s/user/repliesget.go b/internal/api/s2s/user/repliesget.go index 951cc428c..9031b7841 100644 --- a/internal/api/s2s/user/repliesget.go +++ b/internal/api/s2s/user/repliesget.go @@ -1,7 +1,6 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http" @@ -9,7 +8,6 @@ import (  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // StatusRepliesGETHandler swagger:operation GET /users/{username}/statuses/{status}/replies s2sRepliesGet @@ -116,25 +114,19 @@ func (m *Module) StatusRepliesGETHandler(c *gin.Context) {  		minID = minIDString  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	replies, err := m.processor.GetFediStatusReplies(ctx, requestedUsername, requestedStatusID, page, onlyOtherAccounts, minID, c.Request.URL) -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	replies, errWithCode := m.processor.GetFediStatusReplies(ctx, requestedUsername, requestedStatusID, page, onlyOtherAccounts, minID, c.Request.URL) +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} diff --git a/internal/api/s2s/user/statusget.go b/internal/api/s2s/user/statusget.go index 04241d075..20b9064eb 100644 --- a/internal/api/s2s/user/statusget.go +++ b/internal/api/s2s/user/statusget.go @@ -1,14 +1,12 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // StatusGETHandler serves the target status as an activitystreams NOTE so that other AP servers can parse it. @@ -30,25 +28,19 @@ func (m *Module) StatusGETHandler(c *gin.Context) {  		return  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	status, err := m.processor.GetFediStatus(ctx, requestedUsername, requestedStatusID, c.Request.URL) // handles auth as well -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	status, errWithCode := m.processor.GetFediStatus(ctx, requestedUsername, requestedStatusID, c.Request.URL) +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} diff --git a/internal/api/s2s/user/user.go b/internal/api/s2s/user/user.go index b5ff9a699..cd57ab14e 100644 --- a/internal/api/s2s/user/user.go +++ b/internal/api/s2s/user/user.go @@ -61,13 +61,6 @@ const (  	UsersStatusRepliesPath = UsersStatusPath + "/replies"  ) -// ActivityPubAcceptHeaders represents the Accept headers mentioned here: -// https://www.w3.org/TR/activitypub/#retrieving-objects -var ActivityPubAcceptHeaders = []string{ -	`application/activity+json`, -	`application/ld+json; profile="https://www.w3.org/ns/activitystreams"`, -} -  // Module implements the FederationAPIModule interface  type Module struct {  	config    *config.Config diff --git a/internal/api/s2s/user/userget.go b/internal/api/s2s/user/userget.go index f2f846f97..abd52da22 100644 --- a/internal/api/s2s/user/userget.go +++ b/internal/api/s2s/user/userget.go @@ -19,14 +19,12 @@  package user  import ( -	"context"  	"encoding/json"  	"fmt"  	"net/http"  	"github.com/gin-gonic/gin"  	"github.com/sirupsen/logrus" -	"github.com/superseriousbusiness/gotosocial/internal/util"  )  // UsersGETHandler should be served at https://example.org/users/:username. @@ -50,25 +48,19 @@ func (m *Module) UsersGETHandler(c *gin.Context) {  		return  	} -	// make sure this actually an AP request -	format := c.NegotiateFormat(ActivityPubAcceptHeaders...) -	if format == "" { -		c.JSON(http.StatusNotAcceptable, gin.H{"error": "could not negotiate format with given Accept header(s)"}) +	format, err := negotiateFormat(c) +	if err != nil { +		c.JSON(http.StatusNotAcceptable, gin.H{"error": fmt.Sprintf("could not negotiate format with given Accept header(s): %s", err)})  		return  	}  	l.Tracef("negotiated format: %s", format) -	// transfer the signature verifier from the gin context to the request context -	ctx := c.Request.Context() -	verifier, signed := c.Get(string(util.APRequestingPublicKeyVerifier)) -	if signed { -		ctx = context.WithValue(ctx, util.APRequestingPublicKeyVerifier, verifier) -	} +	ctx := populateContext(c) -	user, err := m.processor.GetFediUser(ctx, requestedUsername, c.Request.URL) // GetFediUser handles auth as well -	if err != nil { -		l.Info(err.Error()) -		c.JSON(err.Code(), gin.H{"error": err.Safe()}) +	user, errWithCode := m.processor.GetFediUser(ctx, requestedUsername, c.Request.URL) // GetFediUser handles auth as well +	if errWithCode != nil { +		l.Info(errWithCode.Error()) +		c.JSON(errWithCode.Code(), gin.H{"error": errWithCode.Safe()})  		return  	} | 
