diff options
Diffstat (limited to 'internal/api/client')
-rw-r--r-- | internal/api/client/account/account_test.go | 5 | ||||
-rw-r--r-- | internal/api/client/account/accountcreate.go | 7 | ||||
-rw-r--r-- | internal/api/client/admin/admin_test.go | 5 | ||||
-rw-r--r-- | internal/api/client/admin/mediacleanup.go | 3 | ||||
-rw-r--r-- | internal/api/client/auth/auth_test.go | 5 | ||||
-rw-r--r-- | internal/api/client/followrequest/followrequest_test.go | 5 | ||||
-rw-r--r-- | internal/api/client/instance/instance_test.go | 5 | ||||
-rw-r--r-- | internal/api/client/instance/instanceget.go | 3 | ||||
-rw-r--r-- | internal/api/client/media/mediacreate.go | 10 | ||||
-rw-r--r-- | internal/api/client/media/mediacreate_test.go | 3 | ||||
-rw-r--r-- | internal/api/client/media/mediaupdate.go | 6 | ||||
-rw-r--r-- | internal/api/client/media/mediaupdate_test.go | 3 | ||||
-rw-r--r-- | internal/api/client/status/statuscreate.go | 12 |
13 files changed, 27 insertions, 45 deletions
diff --git a/internal/api/client/account/account_test.go b/internal/api/client/account/account_test.go index d6bb5a5c0..f2114a0f8 100644 --- a/internal/api/client/account/account_test.go +++ b/internal/api/client/account/account_test.go @@ -8,7 +8,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" "github.com/superseriousbusiness/gotosocial/internal/api/client/account" "github.com/superseriousbusiness/gotosocial/internal/concurrency" @@ -90,8 +89,8 @@ func (suite *AccountStandardTestSuite) newContext(recorder *httptest.ResponseRec ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"]) - protocol := viper.GetString(config.Keys.Protocol) - host := viper.GetString(config.Keys.Host) + protocol := config.GetProtocol() + host := config.GetHost() baseURI := fmt.Sprintf("%s://%s", protocol, host) requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath) diff --git a/internal/api/client/account/accountcreate.go b/internal/api/client/account/accountcreate.go index ee9f508d7..35eb36216 100644 --- a/internal/api/client/account/accountcreate.go +++ b/internal/api/client/account/accountcreate.go @@ -24,7 +24,6 @@ import ( "net/http" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/gin-gonic/gin" "github.com/superseriousbusiness/gotosocial/internal/api" @@ -123,9 +122,7 @@ func (m *Module) AccountCreatePOSTHandler(c *gin.Context) { // validateCreateAccount checks through all the necessary prerequisites for creating a new account, // according to the provided account create request. If the account isn't eligible, an error will be returned. func validateCreateAccount(form *model.AccountCreateRequest) error { - keys := config.Keys - - if !viper.GetBool(keys.AccountsRegistrationOpen) { + if !config.GetAccountsRegistrationOpen() { return errors.New("registration is not open for this server") } @@ -149,7 +146,7 @@ func validateCreateAccount(form *model.AccountCreateRequest) error { return err } - if err := validate.SignUpReason(form.Reason, viper.GetBool(keys.AccountsReasonRequired)); err != nil { + if err := validate.SignUpReason(form.Reason, config.GetAccountsReasonRequired()); err != nil { return err } diff --git a/internal/api/client/admin/admin_test.go b/internal/api/client/admin/admin_test.go index 11e2f8354..251a8be9b 100644 --- a/internal/api/client/admin/admin_test.go +++ b/internal/api/client/admin/admin_test.go @@ -26,7 +26,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" "github.com/superseriousbusiness/gotosocial/internal/api/client/admin" "github.com/superseriousbusiness/gotosocial/internal/concurrency" @@ -108,8 +107,8 @@ func (suite *AdminStandardTestSuite) newContext(recorder *httptest.ResponseRecor ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["admin_account"]) ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["admin_account"]) - protocol := viper.GetString(config.Keys.Protocol) - host := viper.GetString(config.Keys.Host) + protocol := config.GetProtocol() + host := config.GetHost() baseURI := fmt.Sprintf("%s://%s", protocol, host) requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath) diff --git a/internal/api/client/admin/mediacleanup.go b/internal/api/client/admin/mediacleanup.go index 508840b23..02eec82f3 100644 --- a/internal/api/client/admin/mediacleanup.go +++ b/internal/api/client/admin/mediacleanup.go @@ -24,7 +24,6 @@ import ( "github.com/gin-gonic/gin" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/superseriousbusiness/gotosocial/internal/api/model" "github.com/superseriousbusiness/gotosocial/internal/config" "github.com/superseriousbusiness/gotosocial/internal/oauth" @@ -93,7 +92,7 @@ func (m *Module) MediaCleanupPOSTHandler(c *gin.Context) { var remoteCacheDays int if form.RemoteCacheDays == nil { - remoteCacheDays = viper.GetInt(config.Keys.MediaRemoteCacheDays) + remoteCacheDays = config.GetMediaRemoteCacheDays() } else { remoteCacheDays = *form.RemoteCacheDays } diff --git a/internal/api/client/auth/auth_test.go b/internal/api/client/auth/auth_test.go index fdf1b6baf..bd1a1948e 100644 --- a/internal/api/client/auth/auth_test.go +++ b/internal/api/client/auth/auth_test.go @@ -26,7 +26,6 @@ import ( "github.com/gin-contrib/sessions" "github.com/gin-contrib/sessions/memstore" "github.com/gin-gonic/gin" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" "github.com/superseriousbusiness/gotosocial/internal/api/client/auth" "github.com/superseriousbusiness/gotosocial/internal/config" @@ -96,8 +95,8 @@ func (suite *AuthStandardTestSuite) newContext(requestMethod string, requestPath testrig.ConfigureTemplatesWithGin(engine) // create the request - protocol := viper.GetString(config.Keys.Protocol) - host := viper.GetString(config.Keys.Host) + protocol := config.GetProtocol() + host := config.GetHost() baseURI := fmt.Sprintf("%s://%s", protocol, host) requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath) ctx.Request = httptest.NewRequest(requestMethod, requestURI, nil) // the endpoint we're hitting diff --git a/internal/api/client/followrequest/followrequest_test.go b/internal/api/client/followrequest/followrequest_test.go index 14b5656b6..b86e22ce4 100644 --- a/internal/api/client/followrequest/followrequest_test.go +++ b/internal/api/client/followrequest/followrequest_test.go @@ -25,7 +25,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" "github.com/superseriousbusiness/gotosocial/internal/api/client/followrequest" "github.com/superseriousbusiness/gotosocial/internal/concurrency" @@ -104,8 +103,8 @@ func (suite *FollowRequestStandardTestSuite) newContext(recorder *httptest.Respo ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"]) - protocol := viper.GetString(config.Keys.Protocol) - host := viper.GetString(config.Keys.Host) + protocol := config.GetProtocol() + host := config.GetHost() baseURI := fmt.Sprintf("%s://%s", protocol, host) requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath) diff --git a/internal/api/client/instance/instance_test.go b/internal/api/client/instance/instance_test.go index a1fe1f17c..7ea7d475c 100644 --- a/internal/api/client/instance/instance_test.go +++ b/internal/api/client/instance/instance_test.go @@ -26,7 +26,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" "github.com/superseriousbusiness/gotosocial/internal/api/client/instance" "github.com/superseriousbusiness/gotosocial/internal/concurrency" @@ -108,8 +107,8 @@ func (suite *InstanceStandardTestSuite) newContext(recorder *httptest.ResponseRe ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["admin_account"]) ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["admin_account"]) - protocol := viper.GetString(config.Keys.Protocol) - host := viper.GetString(config.Keys.Host) + protocol := config.GetProtocol() + host := config.GetHost() baseURI := fmt.Sprintf("%s://%s", protocol, host) requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath) diff --git a/internal/api/client/instance/instanceget.go b/internal/api/client/instance/instanceget.go index 4f9afdb38..cd6dd32cc 100644 --- a/internal/api/client/instance/instanceget.go +++ b/internal/api/client/instance/instanceget.go @@ -4,7 +4,6 @@ import ( "net/http" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/superseriousbusiness/gotosocial/internal/api" "github.com/superseriousbusiness/gotosocial/internal/config" @@ -41,7 +40,7 @@ func (m *Module) InstanceInformationGETHandler(c *gin.Context) { return } - host := viper.GetString(config.Keys.Host) + host := config.GetHost() instance, err := m.processor.InstanceGet(c.Request.Context(), host) if err != nil { diff --git a/internal/api/client/media/mediacreate.go b/internal/api/client/media/mediacreate.go index 5946ed398..ed6a12d37 100644 --- a/internal/api/client/media/mediacreate.go +++ b/internal/api/client/media/mediacreate.go @@ -24,7 +24,6 @@ import ( "net/http" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/gin-gonic/gin" "github.com/superseriousbusiness/gotosocial/internal/api" @@ -133,11 +132,10 @@ func validateCreateMedia(form *model.AttachmentRequest) error { return errors.New("no attachment given") } - keys := config.Keys - maxVideoSize := viper.GetInt(keys.MediaVideoMaxSize) - maxImageSize := viper.GetInt(keys.MediaImageMaxSize) - minDescriptionChars := viper.GetInt(keys.MediaDescriptionMinChars) - maxDescriptionChars := viper.GetInt(keys.MediaDescriptionMaxChars) + maxVideoSize := config.GetMediaVideoMaxSize() + maxImageSize := config.GetMediaImageMaxSize() + minDescriptionChars := config.GetMediaDescriptionMinChars() + maxDescriptionChars := config.GetMediaDescriptionMaxChars() // a very superficial check to see if no size limits are exceeded // we still don't actually know which media types we're dealing with but the other handlers will go into more detail there diff --git a/internal/api/client/media/mediacreate_test.go b/internal/api/client/media/mediacreate_test.go index e16b9f5eb..f39e756f7 100644 --- a/internal/api/client/media/mediacreate_test.go +++ b/internal/api/client/media/mediacreate_test.go @@ -33,7 +33,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" mediamodule "github.com/superseriousbusiness/gotosocial/internal/api/client/media" "github.com/superseriousbusiness/gotosocial/internal/api/model" @@ -261,7 +260,7 @@ func (suite *MediaCreateTestSuite) TestMediaCreateLongDescription() { func (suite *MediaCreateTestSuite) TestMediaCreateTooShortDescription() { // set the min description length - viper.Set(config.Keys.MediaDescriptionMinChars, 500) + config.SetMediaDescriptionMinChars(500) // set up the context for the request t := suite.testTokens["local_account_1"] diff --git a/internal/api/client/media/mediaupdate.go b/internal/api/client/media/mediaupdate.go index ffe3b5e55..21b8c9c8e 100644 --- a/internal/api/client/media/mediaupdate.go +++ b/internal/api/client/media/mediaupdate.go @@ -24,7 +24,6 @@ import ( "net/http" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/gin-gonic/gin" "github.com/superseriousbusiness/gotosocial/internal/api" @@ -141,9 +140,8 @@ func (m *Module) MediaPUTHandler(c *gin.Context) { } func validateUpdateMedia(form *model.AttachmentUpdateRequest) error { - keys := config.Keys - minDescriptionChars := viper.GetInt(keys.MediaDescriptionMinChars) - maxDescriptionChars := viper.GetInt(keys.MediaDescriptionMaxChars) + minDescriptionChars := config.GetMediaDescriptionMinChars() + maxDescriptionChars := config.GetMediaDescriptionMaxChars() if form.Description != nil { if len(*form.Description) < minDescriptionChars || len(*form.Description) > maxDescriptionChars { diff --git a/internal/api/client/media/mediaupdate_test.go b/internal/api/client/media/mediaupdate_test.go index a87718438..fbf794e1d 100644 --- a/internal/api/client/media/mediaupdate_test.go +++ b/internal/api/client/media/mediaupdate_test.go @@ -31,7 +31,6 @@ import ( "codeberg.org/gruf/go-store/kv" "github.com/gin-gonic/gin" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/stretchr/testify/suite" mediamodule "github.com/superseriousbusiness/gotosocial/internal/api/client/media" "github.com/superseriousbusiness/gotosocial/internal/api/model" @@ -188,7 +187,7 @@ func (suite *MediaUpdateTestSuite) TestUpdateImage() { func (suite *MediaUpdateTestSuite) TestUpdateImageShortDescription() { // set the min description length - viper.Set(config.Keys.MediaDescriptionMinChars, 50) + config.SetMediaDescriptionMinChars(50) toUpdate := suite.testAttachments["local_account_1_unattached_1"] diff --git a/internal/api/client/status/statuscreate.go b/internal/api/client/status/statuscreate.go index 406472772..2813efb90 100644 --- a/internal/api/client/status/statuscreate.go +++ b/internal/api/client/status/statuscreate.go @@ -24,7 +24,6 @@ import ( "net/http" "github.com/sirupsen/logrus" - "github.com/spf13/viper" "github.com/gin-gonic/gin" "github.com/superseriousbusiness/gotosocial/internal/api" @@ -130,12 +129,11 @@ func validateCreateStatus(form *model.AdvancedStatusCreateForm) error { return errors.New("can't post media + poll in same status") } - keys := config.Keys - maxChars := viper.GetInt(keys.StatusesMaxChars) - maxMediaFiles := viper.GetInt(keys.StatusesMediaMaxFiles) - maxPollOptions := viper.GetInt(keys.StatusesPollMaxOptions) - maxPollChars := viper.GetInt(keys.StatusesPollOptionMaxChars) - maxCwChars := viper.GetInt(keys.StatusesCWMaxChars) + maxChars := config.GetStatusesMaxChars() + maxMediaFiles := config.GetStatusesMediaMaxFiles() + maxPollOptions := config.GetStatusesPollMaxOptions() + maxPollChars := config.GetStatusesPollOptionMaxChars() + maxCwChars := config.GetStatusesCWMaxChars() // validate status if form.Status != "" { |