diff options
| author |  tobi <tobi.smethurst@protonmail.com> | 2025-06-30 12:56:50 +0200 |
|---|---|---|
| committer |  kim <gruf@noreply.codeberg.org> | 2025-06-30 12:56:50 +0200 |
| commit | 5fbaf5b7bec6f59bb868dd8b76a90c1bbd2986b5 (patch) | |
| tree | 5003d30e1152d491840ef0a3ef7c2e2b69257742 /internal/text/markdown_test.go | |
| parent | [bugfix] fix issues with postgres array serialization (#4295) (diff) | |
| download | gotosocial-5fbaf5b7bec6f59bb868dd8b76a90c1bbd2986b5.tar.xz | |
[feature] Allow anchor href to work for footnotes, use ID prefix to avoid clashes (#4298)
Updates markdown parser + sanitizer to allow footnote anchors to work properly, with appropriate roles. Footnote anchor IDs and backrefs use the status ID as a prefix to avoid clashes, so that footnotes don't break when multiple footnoted statuses are rendered on the same page (eg., in a thread or on the account's home page).
closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4296
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4298
Co-authored-by: tobi <tobi.smethurst@protonmail.com>
Co-committed-by: tobi <tobi.smethurst@protonmail.com>
Diffstat (limited to 'internal/text/markdown_test.go')
| -rw-r--r-- | internal/text/markdown_test.go | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/internal/text/markdown_test.go b/internal/text/markdown_test.go index 347ca2928..14578398d 100644 --- a/internal/text/markdown_test.go +++ b/internal/text/markdown_test.go @@ -61,7 +61,9 @@ const ( mdCodeBlockWithNewlines = "some code coming up\n\n```\n\n\n\n```\nthat was some code" mdCodeBlockWithNewlinesExpected = "<p>some code coming up</p><pre><code>\n\n\n</code></pre><p>that was some code</p>" mdWithFootnote = "fox mulder,fbi.[^1]\n\n[^1]: federated bureau of investigation" - mdWithFootnoteExpected = "<p>fox mulder,fbi.<sup id=\"fnref:1\"><a class=\"footnote-ref\">1</a></sup></p><div><hr><ol><li id=\"fn:1\"><p>federated bureau of investigation <a class=\"footnote-backref\">↩︎</a></p></li></ol></div>" + mdWithFootnoteExpected = "<p>fox mulder,fbi.<sup id=\"dummy_status_ID-fnref:1\"><a href=\"#dummy_status_ID-fn:1\" class=\"footnote-ref\" role=\"doc-noteref\">1</a></sup></p><div><hr><ol><li id=\"dummy_status_ID-fn:1\"><p>federated bureau of investigation <a href=\"#dummy_status_ID-fnref:1\" class=\"footnote-backref\" role=\"doc-backlink\">↩︎</a></p></li></ol></div>" + mdWithAttemptedRelative = "hello this is a cheeky relative link: <a href=\"../sneaky.html\">click it!</a>" + mdWithAttemptedRelativeExpected = "<p>hello this is a cheeky relative link: click it!</p>" mdWithBlockQuote = "get ready, there's a block quote coming:\n\n>line1\n>line2\n>\n>line3\n\n" mdWithBlockQuoteExpected = "<p>get ready, there's a block quote coming:</p><blockquote><p>line1<br>line2</p><p>line3</p></blockquote>" mdHashtagAndCodeBlock = "#Hashtag\n\n```\n#Hashtag\n```" @@ -156,6 +158,11 @@ func (suite *MarkdownTestSuite) TestParseWithFootnote() { suite.Equal(mdWithFootnoteExpected, formatted.HTML) } +func (suite *MarkdownTestSuite) TestParseWithAttemptedRelative() { + formatted := suite.FromMarkdown(mdWithAttemptedRelative) + suite.Equal(mdWithAttemptedRelativeExpected, formatted.HTML) +} + func (suite *MarkdownTestSuite) TestParseWithBlockquote() { formatted := suite.FromMarkdown(mdWithBlockQuote) suite.Equal(mdWithBlockQuoteExpected, formatted.HTML) |