[performance] filter model and database table improvements (#4277)

- removes unnecessary fields / columns (created_at, updated_at)
- replaces filter.context_* columns with singular filter.contexts bit field which should save both struct memory and database space
- replaces filter.action string with integer enum type which should save both struct memory and database space
- adds links from filter to filter_* tables with Filter{}.KeywordIDs and Filter{}.StatusIDs fields (this also means we now have those ID slices cached, which reduces some lookups)
- removes account_id fields from filter_* tables, since there's a more direct connection between filter and filter_* tables, and filter.account_id already exists
- refactors a bunch of the filter processor logic to save on code repetition, factor in the above changes, fix a few bugs with missed error returns and bring it more in-line with some of our newer code

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4277
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>

1 files changed, 15 insertions, 15 deletions

diff --git a/internal/processing/timeline/home_test.go b/internal/processing/timeline/home_test.go
index 184d361f0..2d0c912f8 100644
--- a/internal/processing/timeline/home_test.go
+++ b/internal/processing/timeline/home_test.go
@@ -24,7 +24,6 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/id"
 	"code.superseriousbusiness.org/gotosocial/internal/paging"
-	"code.superseriousbusiness.org/gotosocial/internal/util"
 	"github.com/stretchr/testify/suite"
 )
 
@@ -49,24 +48,20 @@ func (suite *HomeTestSuite) TestHomeTimelineGetHideFiltered() {
 		filteredStatus      = suite.testStatuses["admin_account_status_2"]
 		filteredStatusFound = false
 		filterID            = id.NewULID()
-		filter              = &gtsmodel.Filter{
+		filterStatusID      = id.NewULID()
+		filterStatus        = &gtsmodel.FilterStatus{
+			ID:       filterStatusID,
+			FilterID: filterID,
+			StatusID: filteredStatus.ID,
+		}
+		filter = &gtsmodel.Filter{
 			ID:        filterID,
 			AccountID: requester.ID,
 			Title:     "timeline filtering test",
 			Action:    gtsmodel.FilterActionHide,
-			Statuses: []*gtsmodel.FilterStatus{
-				{
-					ID:        id.NewULID(),
-					AccountID: requester.ID,
-					FilterID:  filterID,
-					StatusID:  filteredStatus.ID,
-				},
-			},
-			ContextHome:          util.Ptr(true),
-			ContextNotifications: util.Ptr(false),
-			ContextPublic:        util.Ptr(false),
-			ContextThread:        util.Ptr(false),
-			ContextAccount:       util.Ptr(false),
+			Statuses:  []*gtsmodel.FilterStatus{filterStatus},
+			StatusIDs: []string{filterStatusID},
+			Contexts:  gtsmodel.FilterContexts(gtsmodel.FilterContextHome),
 		}
 	)
 
@@ -95,6 +90,11 @@ func (suite *HomeTestSuite) TestHomeTimelineGetHideFiltered() {
 	// Clear the timeline to drop all cached statuses.
 	suite.state.Caches.Timelines.Home.Clear(requester.ID)
 
+	// Create the filter status associated with the main filter.
+	if err := suite.db.PutFilterStatus(ctx, filterStatus); err != nil {
+		suite.FailNow(err.Error())
+	}
+
 	// Create a filter to hide one status on the timeline.
 	if err := suite.db.PutFilter(ctx, filter); err != nil {
 		suite.FailNow(err.Error())