[bugfix] more RSS validation issues (#4517)

Fixes some validation issues relating to author information often expected to be valid email addresses, which our @displayname@username is not. There's still a few more validation issues, but honestly if we're going have better support I think it might be worth dropping gorilla/feeds for our own tagged XML / JSON structs.

Also does a bunch of housekeeping in the typeutils package removing error returns where never used / only ever logged, removing unused contexts etc.

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4517
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>

1 files changed, 3 insertions, 7 deletions

diff --git a/internal/processing/media/create.go b/internal/processing/media/create.go
index e925297ff..aaccf4bde 100644
--- a/internal/processing/media/create.go
+++ b/internal/processing/media/create.go
@@ -29,6 +29,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtserror"
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/media"
+	"code.superseriousbusiness.org/gotosocial/internal/typeutils"
 	"codeberg.org/gruf/go-iotools"
 )
 
@@ -89,11 +90,6 @@ func (p *Processor) Create(ctx context.Context, account *gtsmodel.Account, form
 		return nil, errWithCode
 	}
 
-	apiAttachment, err := p.converter.AttachmentToAPIAttachment(ctx, attachment)
-	if err != nil {
-		err := fmt.Errorf("error parsing media attachment to frontend type: %s", err)
-		return nil, gtserror.NewErrorInternalError(err)
-	}
-
-	return &apiAttachment, nil
+	a := typeutils.AttachmentToAPIAttachment(attachment)
+	return &a, nil
 }