[chore] various federatingdb tweaks (#4178)

after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller

frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/internal/federation/federatingdb/follow.go b/internal/federation/federatingdb/follow.go
index f8ae8c580..9bd602489 100644
--- a/internal/federation/federatingdb/follow.go
+++ b/internal/federation/federatingdb/follow.go
@@ -29,7 +29,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/messages"
 )
 
-func (f *federatingDB) Follow(ctx context.Context, followable vocab.ActivityStreamsFollow) error {
+func (f *DB) Follow(ctx context.Context, followable vocab.ActivityStreamsFollow) error {
 	log.DebugKV(ctx, "follow", serialize{followable})
 
 	// Mark activity as handled.