diff options
| author |  kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> | 2023-07-25 09:34:05 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2023-07-25 10:34:05 +0200 |
| commit | 5f3e0957179eddd088e82b8f8f493164cbc9ce37 (patch) | |
| tree | b169630ef1ac269dc96d74b533f6663dc0f1e6fc /internal/db/statusbookmark.go | |
| parent | [feature/performance] support uncaching remote emoji + scheduled cleanup func... (diff) | |
| download | gotosocial-5f3e0957179eddd088e82b8f8f493164cbc9ce37.tar.xz | |
[performance] retry db queries on busy errors (#2025)
* catch SQLITE_BUSY errors, wrap bun.DB to use our own busy retrier, remove unnecessary db.Error type
Signed-off-by: kim <grufwub@gmail.com>
* remove dead code
Signed-off-by: kim <grufwub@gmail.com>
* remove more dead code, add missing error arguments
Signed-off-by: kim <grufwub@gmail.com>
* update sqlite to use maxOpenConns()
Signed-off-by: kim <grufwub@gmail.com>
* add uncommitted changes
Signed-off-by: kim <grufwub@gmail.com>
* use direct calls-through for the ConnIface to make sure we don't double query hook
Signed-off-by: kim <grufwub@gmail.com>
* expose underlying bun.DB better
Signed-off-by: kim <grufwub@gmail.com>
* retry on the correct busy error
Signed-off-by: kim <grufwub@gmail.com>
* use longer possible maxRetries for db retry-backoff
Signed-off-by: kim <grufwub@gmail.com>
* remove the note regarding max-open-conns only applying to postgres
Signed-off-by: kim <grufwub@gmail.com>
* improved code commenting
Signed-off-by: kim <grufwub@gmail.com>
* remove unnecessary infof call (just use info)
Signed-off-by: kim <grufwub@gmail.com>
* rename DBConn to WrappedDB to better follow sql package name conventions
Signed-off-by: kim <grufwub@gmail.com>
* update test error string checks
Signed-off-by: kim <grufwub@gmail.com>
* shush linter
Signed-off-by: kim <grufwub@gmail.com>
* update backoff logic to be more transparent
Signed-off-by: kim <grufwub@gmail.com>
---------
Signed-off-by: kim <grufwub@gmail.com>
Diffstat (limited to 'internal/db/statusbookmark.go')
| -rw-r--r-- | internal/db/statusbookmark.go | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/internal/db/statusbookmark.go b/internal/db/statusbookmark.go index e47bfc54d..542e49f17 100644 --- a/internal/db/statusbookmark.go +++ b/internal/db/statusbookmark.go @@ -25,24 +25,24 @@ import ( type StatusBookmark interface { // GetStatusBookmark gets one status bookmark with the given ID. - GetStatusBookmark(ctx context.Context, id string) (*gtsmodel.StatusBookmark, Error) + GetStatusBookmark(ctx context.Context, id string) (*gtsmodel.StatusBookmark, error) // GetStatusBookmarkID is a shortcut function for returning just the database ID // of a status bookmark created by the given accountID, targeting the given statusID. - GetStatusBookmarkID(ctx context.Context, accountID string, statusID string) (string, Error) + GetStatusBookmarkID(ctx context.Context, accountID string, statusID string) (string, error) // GetStatusBookmarks retrieves status bookmarks created by the given accountID, // and using the provided parameters. If limit is < 0 then no limit will be set. // // This function is primarily useful for paging through bookmarks in a sort of // timeline view. - GetStatusBookmarks(ctx context.Context, accountID string, limit int, maxID string, minID string) ([]*gtsmodel.StatusBookmark, Error) + GetStatusBookmarks(ctx context.Context, accountID string, limit int, maxID string, minID string) ([]*gtsmodel.StatusBookmark, error) // PutStatusBookmark inserts the given statusBookmark into the database. - PutStatusBookmark(ctx context.Context, statusBookmark *gtsmodel.StatusBookmark) Error + PutStatusBookmark(ctx context.Context, statusBookmark *gtsmodel.StatusBookmark) error // DeleteStatusBookmark deletes one status bookmark with the given ID. - DeleteStatusBookmark(ctx context.Context, id string) Error + DeleteStatusBookmark(ctx context.Context, id string) error // DeleteStatusBookmarks mass deletes status bookmarks targeting targetAccountID // and/or originating from originAccountID and/or bookmarking statusID. @@ -57,10 +57,10 @@ type StatusBookmark interface { // originate from originAccountID will be deleted. // // At least one parameter must not be an empty string. - DeleteStatusBookmarks(ctx context.Context, targetAccountID string, originAccountID string) Error + DeleteStatusBookmarks(ctx context.Context, targetAccountID string, originAccountID string) error // DeleteStatusBookmarksForStatus deletes all status bookmarks that target the // given status ID. This is useful when a status has been deleted, and you need // to clean up after it. - DeleteStatusBookmarksForStatus(ctx context.Context, statusID string) Error + DeleteStatusBookmarksForStatus(ctx context.Context, statusID string) error } |