diff options
| author | 2023-02-25 13:16:30 +0100 | |
|---|---|---|
| committer | 2023-02-25 12:16:30 +0000 | |
| commit | c27b4d7ed02cdabac00c3ddedb8201b74f745ec6 (patch) | |
| tree | d80f621241fd67a4e5de2d21a8c24776552175f5 /internal/api | |
| parent | [chore] Update gin to v1.9.0 (#1553) (diff) | |
| download | gotosocial-c27b4d7ed02cdabac00c3ddedb8201b74f745ec6.tar.xz | |
[feature] Client API endpoints + v. basic web view for pinned posts (#1547)
* implement status pin client api + web handler
* make test names + comments more descriptive
* don't use separate table for status pins
* remove unused add + remove checking
* tidy up + add some more tests
Diffstat (limited to 'internal/api')
| -rw-r--r-- | internal/api/activitypub/users/inboxpost_test.go | 2 | ||||
| -rw-r--r-- | internal/api/client/accounts/statuses_test.go | 179 | ||||
| -rw-r--r-- | internal/api/client/statuses/status.go | 4 | ||||
| -rw-r--r-- | internal/api/client/statuses/statuspin.go | 103 | ||||
| -rw-r--r-- | internal/api/client/statuses/statuspin_test.go | 198 | ||||
| -rw-r--r-- | internal/api/client/statuses/statusunpin.go | 98 | 
6 files changed, 578 insertions, 6 deletions
diff --git a/internal/api/activitypub/users/inboxpost_test.go b/internal/api/activitypub/users/inboxpost_test.go index e43532e80..0ad63abf7 100644 --- a/internal/api/activitypub/users/inboxpost_test.go +++ b/internal/api/activitypub/users/inboxpost_test.go @@ -481,7 +481,7 @@ func (suite *InboxPostTestSuite) TestPostDelete() {  	}  	// no statuses from foss satan should be left in the database -	dbStatuses, err := suite.db.GetAccountStatuses(ctx, deletedAccount.ID, 0, false, false, "", "", false, false, false) +	dbStatuses, err := suite.db.GetAccountStatuses(ctx, deletedAccount.ID, 0, false, false, "", "", false, false)  	suite.ErrorIs(err, db.ErrNoEntries)  	suite.Empty(dbStatuses) diff --git a/internal/api/client/accounts/statuses_test.go b/internal/api/client/accounts/statuses_test.go index 5676d79e0..fdf2efac3 100644 --- a/internal/api/client/accounts/statuses_test.go +++ b/internal/api/client/accounts/statuses_test.go @@ -27,10 +27,10 @@ import (  	"testing"  	"github.com/gin-gonic/gin" -	"github.com/stretchr/testify/assert"  	"github.com/stretchr/testify/suite"  	"github.com/superseriousbusiness/gotosocial/internal/api/client/accounts"  	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model" +	"github.com/superseriousbusiness/gotosocial/internal/oauth"  )  type AccountStatusesTestSuite struct { @@ -62,7 +62,7 @@ func (suite *AccountStatusesTestSuite) TestGetStatusesPublicOnly() {  	// check the response  	b, err := ioutil.ReadAll(result.Body) -	assert.NoError(suite.T(), err) +	suite.NoError(err)  	// unmarshal the returned statuses  	apimodelStatuses := []*apimodel.Status{} @@ -74,7 +74,7 @@ func (suite *AccountStatusesTestSuite) TestGetStatusesPublicOnly() {  		suite.Equal(apimodel.VisibilityPublic, s.Visibility)  	} -	suite.Equal(`<http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&max_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned_only=false&only_media=false&only_public=true>; rel="next", <http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&min_id=01G36SF3V6Y6V5BF9P4R7PQG7G&exclude_replies=false&exclude_reblogs=false&pinned_only=false&only_media=false&only_public=true>; rel="prev"`, result.Header.Get("link")) +	suite.Equal(`<http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&max_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned=false&only_media=false&only_public=true>; rel="next", <http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&min_id=01G36SF3V6Y6V5BF9P4R7PQG7G&exclude_replies=false&exclude_reblogs=false&pinned=false&only_media=false&only_public=true>; rel="prev"`, result.Header.Get("link"))  }  func (suite *AccountStatusesTestSuite) TestGetStatusesPublicOnlyMediaOnly() { @@ -102,7 +102,7 @@ func (suite *AccountStatusesTestSuite) TestGetStatusesPublicOnlyMediaOnly() {  	// check the response  	b, err := ioutil.ReadAll(result.Body) -	assert.NoError(suite.T(), err) +	suite.NoError(err)  	// unmarshal the returned statuses  	apimodelStatuses := []*apimodel.Status{} @@ -115,7 +115,176 @@ func (suite *AccountStatusesTestSuite) TestGetStatusesPublicOnlyMediaOnly() {  		suite.Equal(apimodel.VisibilityPublic, s.Visibility)  	} -	suite.Equal(`<http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&max_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned_only=false&only_media=true&only_public=true>; rel="next", <http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&min_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned_only=false&only_media=true&only_public=true>; rel="prev"`, result.Header.Get("link")) +	suite.Equal(`<http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&max_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned=false&only_media=true&only_public=true>; rel="next", <http://localhost:8080/api/v1/accounts/01F8MH17FWEB39HZJ76B6VXSKF/statuses?limit=20&min_id=01F8MH75CBF9JFX4ZAD54N0W0R&exclude_replies=false&exclude_reblogs=false&pinned=false&only_media=true&only_public=true>; rel="prev"`, result.Header.Get("link")) +} + +func (suite *AccountStatusesTestSuite) TestGetStatusesPinnedOnlyPublicPins() { +	// admin has a couple statuses pinned +	// we're getting pinned statuses of admin, as local account 1 +	targetAccount := suite.testAccounts["admin_account"] +	recorder := httptest.NewRecorder() +	ctx := suite.newContext(recorder, http.MethodGet, nil, fmt.Sprintf("/api/v1/accounts/%s/statuses?pinned=true", targetAccount.ID), "") +	ctx.Params = gin.Params{ +		gin.Param{ +			Key:   accounts.IDKey, +			Value: targetAccount.ID, +		}, +	} + +	// call the handler +	suite.accountsModule.AccountStatusesGETHandler(ctx) + +	// 1. we should have OK because our request was valid +	suite.Equal(http.StatusOK, recorder.Code) + +	// 2. we should have no error message in the result body +	result := recorder.Result() +	defer result.Body.Close() + +	// check the response +	b, err := ioutil.ReadAll(result.Body) +	suite.NoError(err) + +	// unmarshal the returned statuses +	apimodelStatuses := []*apimodel.Status{} +	err = json.Unmarshal(b, &apimodelStatuses) +	suite.NoError(err) +	suite.Len(apimodelStatuses, 2) +	suite.Empty(result.Header.Get("link")) + +	for _, s := range apimodelStatuses { +		// Requesting account doesn't own these +		// statuses, so pinned should be false. +		suite.False(s.Pinned) +	} +} + +func (suite *AccountStatusesTestSuite) TestGetStatusesPinnedOnlyNotFollowing() { +	// local account 2 has a followers-only status pinned +	// we're getting pinned statuses of local account 2 with an account that doesn't follow it +	targetAccount := suite.testAccounts["local_account_2"] +	recorder := httptest.NewRecorder() +	ctx := suite.newContext(recorder, http.MethodGet, nil, fmt.Sprintf("/api/v1/accounts/%s/statuses?pinned=true", targetAccount.ID), "") +	ctx.Set(oauth.SessionAuthorizedAccount, suite.testAccounts["admin_account"]) +	ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(suite.testTokens["admin_account"])) +	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) +	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["admin_account"]) +	ctx.Params = gin.Params{ +		gin.Param{ +			Key:   accounts.IDKey, +			Value: targetAccount.ID, +		}, +	} + +	// call the handler +	suite.accountsModule.AccountStatusesGETHandler(ctx) + +	// 1. we should have OK because our request was valid +	suite.Equal(http.StatusOK, recorder.Code) + +	// 2. we should have no error message in the result body +	result := recorder.Result() +	defer result.Body.Close() + +	// check the response +	b, err := ioutil.ReadAll(result.Body) +	suite.NoError(err) + +	// unmarshal the returned statuses +	apimodelStatuses := []*apimodel.Status{} +	err = json.Unmarshal(b, &apimodelStatuses) +	suite.NoError(err) +	suite.Empty(apimodelStatuses) +	suite.Empty(result.Header.Get("link")) +} + +func (suite *AccountStatusesTestSuite) TestGetStatusesPinnedOnlyFollowing() { +	// local account 2 has a followers-only status pinned +	// we're getting pinned statuses of local account 2 with an account that *DOES* follow it +	targetAccount := suite.testAccounts["local_account_2"] +	recorder := httptest.NewRecorder() +	ctx := suite.newContext(recorder, http.MethodGet, nil, fmt.Sprintf("/api/v1/accounts/%s/statuses?pinned=true", targetAccount.ID), "") +	ctx.Set(oauth.SessionAuthorizedAccount, suite.testAccounts["local_account_1"]) +	ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(suite.testTokens["local_account_1"])) +	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) +	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"]) +	ctx.Params = gin.Params{ +		gin.Param{ +			Key:   accounts.IDKey, +			Value: targetAccount.ID, +		}, +	} + +	// call the handler +	suite.accountsModule.AccountStatusesGETHandler(ctx) + +	// 1. we should have OK because our request was valid +	suite.Equal(http.StatusOK, recorder.Code) + +	// 2. we should have no error message in the result body +	result := recorder.Result() +	defer result.Body.Close() + +	// check the response +	b, err := ioutil.ReadAll(result.Body) +	suite.NoError(err) + +	// unmarshal the returned statuses +	apimodelStatuses := []*apimodel.Status{} +	err = json.Unmarshal(b, &apimodelStatuses) +	suite.NoError(err) +	suite.Len(apimodelStatuses, 1) +	suite.Empty(result.Header.Get("link")) + +	for _, s := range apimodelStatuses { +		// Requesting account doesn't own these +		// statuses, so pinned should be false. +		suite.False(s.Pinned) +	} +} + +func (suite *AccountStatusesTestSuite) TestGetStatusesPinnedOnlyGetOwn() { +	// local account 2 has a followers-only status pinned +	// we're getting pinned statuses of local account 2 with local account 2! +	targetAccount := suite.testAccounts["local_account_2"] +	recorder := httptest.NewRecorder() +	ctx := suite.newContext(recorder, http.MethodGet, nil, fmt.Sprintf("/api/v1/accounts/%s/statuses?pinned=true", targetAccount.ID), "") +	ctx.Set(oauth.SessionAuthorizedAccount, suite.testAccounts["local_account_2"]) +	ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(suite.testTokens["local_account_2"])) +	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) +	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_2"]) +	ctx.Params = gin.Params{ +		gin.Param{ +			Key:   accounts.IDKey, +			Value: targetAccount.ID, +		}, +	} + +	// call the handler +	suite.accountsModule.AccountStatusesGETHandler(ctx) + +	// 1. we should have OK because our request was valid +	suite.Equal(http.StatusOK, recorder.Code) + +	// 2. we should have no error message in the result body +	result := recorder.Result() +	defer result.Body.Close() + +	// check the response +	b, err := ioutil.ReadAll(result.Body) +	suite.NoError(err) + +	// unmarshal the returned statuses +	apimodelStatuses := []*apimodel.Status{} +	err = json.Unmarshal(b, &apimodelStatuses) +	suite.NoError(err) +	suite.Len(apimodelStatuses, 1) +	suite.Empty(result.Header.Get("link")) + +	for _, s := range apimodelStatuses { +		// Requesting account owns pinned statuses. +		suite.True(s.Pinned) +	}  }  func TestAccountStatusesTestSuite(t *testing.T) { diff --git a/internal/api/client/statuses/status.go b/internal/api/client/statuses/status.go index 380846ed4..d709d80ea 100644 --- a/internal/api/client/statuses/status.go +++ b/internal/api/client/statuses/status.go @@ -88,6 +88,10 @@ func (m *Module) Route(attachHandler func(method string, path string, f ...gin.H  	attachHandler(http.MethodPost, UnfavouritePath, m.StatusUnfavePOSTHandler)  	attachHandler(http.MethodGet, FavouritedPath, m.StatusFavedByGETHandler) +	// pin stuff +	attachHandler(http.MethodPost, PinPath, m.StatusPinPOSTHandler) +	attachHandler(http.MethodPost, UnpinPath, m.StatusUnpinPOSTHandler) +  	// reblog stuff  	attachHandler(http.MethodPost, ReblogPath, m.StatusBoostPOSTHandler)  	attachHandler(http.MethodPost, UnreblogPath, m.StatusUnboostPOSTHandler) diff --git a/internal/api/client/statuses/statuspin.go b/internal/api/client/statuses/statuspin.go new file mode 100644 index 000000000..54508f51a --- /dev/null +++ b/internal/api/client/statuses/statuspin.go @@ -0,0 +1,103 @@ +/* +   GoToSocial +   Copyright (C) 2021-2023 GoToSocial Authors admin@gotosocial.org + +   This program is free software: you can redistribute it and/or modify +   it under the terms of the GNU Affero General Public License as published by +   the Free Software Foundation, either version 3 of the License, or +   (at your option) any later version. + +   This program is distributed in the hope that it will be useful, +   but WITHOUT ANY WARRANTY; without even the implied warranty of +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the +   GNU Affero General Public License for more details. + +   You should have received a copy of the GNU Affero General Public License +   along with this program.  If not, see <http://www.gnu.org/licenses/>. +*/ + +package statuses + +import ( +	"errors" +	"net/http" + +	"github.com/gin-gonic/gin" +	apiutil "github.com/superseriousbusiness/gotosocial/internal/api/util" +	"github.com/superseriousbusiness/gotosocial/internal/gtserror" +	"github.com/superseriousbusiness/gotosocial/internal/oauth" +) + +// StatusPinPOSTHandler swagger:operation POST /api/v1/statuses/{id}/pin statusPin +// +// Pin a status to the top of your profile, and add it to your Featured ActivityPub collection. +// +// You can only pin original posts (not reblogs) that you authored yourself. +// +// Supported privacy levels for pinned posts are public, unlisted, and private/followers-only, +// but only public posts will appear on the web version of your profile. +// +//	--- +//	tags: +//	- statuses +// +//	produces: +//	- application/json +// +//	parameters: +//	- +//		name: id +//		type: string +//		description: Target status ID. +//		in: path +//		required: true +// +//	security: +//	- OAuth2 Bearer: +//		- write:accounts +// +//	responses: +//		'200': +//			name: status +//			description: The status. +//			schema: +//				"$ref": "#/definitions/status" +//		'400': +//			description: bad request +//		'401': +//			description: unauthorized +//		'403': +//			description: forbidden +//		'404': +//			description: not found +//		'406': +//			description: not acceptable +//		'500': +//			description: internal server error +func (m *Module) StatusPinPOSTHandler(c *gin.Context) { +	authed, err := oauth.Authed(c, true, true, true, true) +	if err != nil { +		apiutil.ErrorHandler(c, gtserror.NewErrorUnauthorized(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	if _, err := apiutil.NegotiateAccept(c, apiutil.JSONAcceptHeaders...); err != nil { +		apiutil.ErrorHandler(c, gtserror.NewErrorNotAcceptable(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	targetStatusID := c.Param(IDKey) +	if targetStatusID == "" { +		err := errors.New("no status id specified") +		apiutil.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	apiStatus, errWithCode := m.processor.Status().PinCreate(c.Request.Context(), authed.Account, targetStatusID) +	if errWithCode != nil { +		apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1) +		return +	} + +	c.JSON(http.StatusOK, apiStatus) +} diff --git a/internal/api/client/statuses/statuspin_test.go b/internal/api/client/statuses/statuspin_test.go new file mode 100644 index 000000000..69cf34eff --- /dev/null +++ b/internal/api/client/statuses/statuspin_test.go @@ -0,0 +1,198 @@ +/* +   GoToSocial +   Copyright (C) 2021-2023 GoToSocial Authors admin@gotosocial.org + +   This program is free software: you can redistribute it and/or modify +   it under the terms of the GNU Affero General Public License as published by +   the Free Software Foundation, either version 3 of the License, or +   (at your option) any later version. + +   This program is distributed in the hope that it will be useful, +   but WITHOUT ANY WARRANTY; without even the implied warranty of +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the +   GNU Affero General Public License for more details. + +   You should have received a copy of the GNU Affero General Public License +   along with this program.  If not, see <http://www.gnu.org/licenses/>. +*/ + +package statuses_test + +import ( +	"context" +	"encoding/json" +	"fmt" +	"io/ioutil" +	"net/http" +	"net/http/httptest" +	"strconv" +	"testing" +	"time" + +	"github.com/stretchr/testify/suite" +	"github.com/superseriousbusiness/gotosocial/internal/ap" +	"github.com/superseriousbusiness/gotosocial/internal/api/client/statuses" +	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model" +	"github.com/superseriousbusiness/gotosocial/internal/config" +	"github.com/superseriousbusiness/gotosocial/internal/gtserror" +	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel" +	"github.com/superseriousbusiness/gotosocial/internal/id" +	"github.com/superseriousbusiness/gotosocial/internal/oauth" +	"github.com/superseriousbusiness/gotosocial/testrig" +) + +type StatusPinTestSuite struct { +	StatusStandardTestSuite +} + +func (suite *StatusPinTestSuite) createPin( +	expectedHTTPStatus int, +	expectedBody string, +	targetStatusID string, +) (*apimodel.Status, error) { +	// instantiate recorder + test context +	recorder := httptest.NewRecorder() +	ctx, _ := testrig.CreateGinTestContext(recorder, nil) +	ctx.Set(oauth.SessionAuthorizedAccount, suite.testAccounts["local_account_1"]) +	ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(suite.testTokens["local_account_1"])) +	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"]) +	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"]) + +	// create the request +	ctx.Request = httptest.NewRequest(http.MethodPost, config.GetProtocol()+"://"+config.GetHost()+"/api/"+statuses.BasePath+"/"+targetStatusID+"/pin", nil) +	ctx.Request.Header.Set("accept", "application/json") +	ctx.AddParam(statuses.IDKey, targetStatusID) + +	// trigger the handler +	suite.statusModule.StatusPinPOSTHandler(ctx) + +	// read the response +	result := recorder.Result() +	defer result.Body.Close() + +	b, err := ioutil.ReadAll(result.Body) +	if err != nil { +		return nil, err +	} + +	errs := gtserror.MultiError{} + +	// check code + body +	if resultCode := recorder.Code; expectedHTTPStatus != resultCode { +		errs = append(errs, fmt.Sprintf("expected %d got %d", expectedHTTPStatus, resultCode)) +	} + +	// if we got an expected body, return early +	if expectedBody != "" && string(b) != expectedBody { +		errs = append(errs, fmt.Sprintf("expected %s got %s", expectedBody, string(b))) +	} + +	if len(errs) > 0 { +		return nil, errs.Combine() +	} + +	resp := &apimodel.Status{} +	if err := json.Unmarshal(b, resp); err != nil { +		return nil, err +	} + +	return resp, nil +} + +func (suite *StatusPinTestSuite) TestPinStatusPublicOK() { +	// Pin an unpinned public status that this account owns. +	targetStatus := suite.testStatuses["local_account_1_status_1"] + +	resp, err := suite.createPin(http.StatusOK, "", targetStatus.ID) +	if err != nil { +		suite.FailNow(err.Error()) +	} + +	suite.True(resp.Pinned) +} + +func (suite *StatusPinTestSuite) TestPinStatusFollowersOnlyOK() { +	// Pin an unpinned followers only status that this account owns. +	targetStatus := suite.testStatuses["local_account_1_status_5"] + +	resp, err := suite.createPin(http.StatusOK, "", targetStatus.ID) +	if err != nil { +		suite.FailNow(err.Error()) +	} + +	suite.True(resp.Pinned) +} + +func (suite *StatusPinTestSuite) TestPinStatusTwiceError() { +	// Try to pin a status that's already been pinned. +	targetStatus := >smodel.Status{} +	*targetStatus = *suite.testStatuses["local_account_1_status_5"] +	targetStatus.PinnedAt = time.Now() + +	if err := suite.db.UpdateStatus(context.Background(), targetStatus); err != nil { +		suite.FailNow(err.Error()) +	} + +	if _, err := suite.createPin( +		http.StatusUnprocessableEntity, +		`{"error":"Unprocessable Entity: status already pinned"}`, +		targetStatus.ID, +	); err != nil { +		suite.FailNow(err.Error()) +	} +} + +func (suite *StatusPinTestSuite) TestPinStatusOtherAccountError() { +	// Try to pin a status that doesn't belong to us. +	targetStatus := suite.testStatuses["admin_account_status_1"] + +	if _, err := suite.createPin( +		http.StatusUnprocessableEntity, +		`{"error":"Unprocessable Entity: status 01F8MH75CBF9JFX4ZAD54N0W0R does not belong to account 01F8MH1H7YV1Z7D2C8K2730QBF"}`, +		targetStatus.ID, +	); err != nil { +		suite.FailNow(err.Error()) +	} +} + +func (suite *StatusPinTestSuite) TestPinStatusTooManyPins() { +	// Test pinning too many statuses. +	testAccount := suite.testAccounts["local_account_1"] + +	// Spam 10 pinned statuses into the database. +	ctx := context.Background() +	for i := range make([]interface{}, 10) { +		status := >smodel.Status{ +			ID:                  id.NewULID(), +			PinnedAt:            time.Now(), +			URL:                 "stub " + strconv.Itoa(i), +			URI:                 "stub " + strconv.Itoa(i), +			Local:               testrig.TrueBool(), +			AccountID:           testAccount.ID, +			AccountURI:          testAccount.URI, +			Visibility:          gtsmodel.VisibilityPublic, +			Federated:           testrig.TrueBool(), +			Boostable:           testrig.TrueBool(), +			Replyable:           testrig.TrueBool(), +			Likeable:            testrig.TrueBool(), +			ActivityStreamsType: ap.ObjectNote, +		} +		if err := suite.db.PutStatus(ctx, status); err != nil { +			suite.FailNow(err.Error()) +		} +	} + +	// Try to pin one more status as a treat. +	targetStatus := suite.testStatuses["local_account_1_status_1"] +	if _, err := suite.createPin( +		http.StatusUnprocessableEntity, +		`{"error":"Unprocessable Entity: status pin limit exceeded, you've already pinned 10 status(es) out of 10"}`, +		targetStatus.ID, +	); err != nil { +		suite.FailNow(err.Error()) +	} +} + +func TestStatusPinTestSuite(t *testing.T) { +	suite.Run(t, new(StatusPinTestSuite)) +} diff --git a/internal/api/client/statuses/statusunpin.go b/internal/api/client/statuses/statusunpin.go new file mode 100644 index 000000000..6a14b109e --- /dev/null +++ b/internal/api/client/statuses/statusunpin.go @@ -0,0 +1,98 @@ +/* +   GoToSocial +   Copyright (C) 2021-2023 GoToSocial Authors admin@gotosocial.org + +   This program is free software: you can redistribute it and/or modify +   it under the terms of the GNU Affero General Public License as published by +   the Free Software Foundation, either version 3 of the License, or +   (at your option) any later version. + +   This program is distributed in the hope that it will be useful, +   but WITHOUT ANY WARRANTY; without even the implied warranty of +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the +   GNU Affero General Public License for more details. + +   You should have received a copy of the GNU Affero General Public License +   along with this program.  If not, see <http://www.gnu.org/licenses/>. +*/ + +package statuses + +import ( +	"errors" +	"net/http" + +	"github.com/gin-gonic/gin" +	apiutil "github.com/superseriousbusiness/gotosocial/internal/api/util" +	"github.com/superseriousbusiness/gotosocial/internal/gtserror" +	"github.com/superseriousbusiness/gotosocial/internal/oauth" +) + +// StatusUnpinPOSTHandler swagger:operation POST /api/v1/statuses/{id}/unpin statusUnpin +// +// Unpin one of your pinned statuses. +// +//	--- +//	tags: +//	- statuses +// +//	produces: +//	- application/json +// +//	parameters: +//	- +//		name: id +//		type: string +//		description: Target status ID. +//		in: path +//		required: true +// +//	security: +//	- OAuth2 Bearer: +//		- write:accounts +// +//	responses: +//		'200': +//			name: status +//			description: The status. +//			schema: +//				"$ref": "#/definitions/status" +//		'400': +//			description: bad request +//		'401': +//			description: unauthorized +//		'403': +//			description: forbidden +//		'404': +//			description: not found +//		'406': +//			description: not acceptable +//		'500': +//			description: internal server error +func (m *Module) StatusUnpinPOSTHandler(c *gin.Context) { +	authed, err := oauth.Authed(c, true, true, true, true) +	if err != nil { +		apiutil.ErrorHandler(c, gtserror.NewErrorUnauthorized(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	if _, err := apiutil.NegotiateAccept(c, apiutil.JSONAcceptHeaders...); err != nil { +		apiutil.ErrorHandler(c, gtserror.NewErrorNotAcceptable(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	targetStatusID := c.Param(IDKey) +	if targetStatusID == "" { +		err := errors.New("no status id specified") +		apiutil.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGetV1) +		return +	} + +	apiStatus, errWithCode := m.processor.Status().PinRemove(c.Request.Context(), authed.Account, targetStatusID) +	if errWithCode != nil { +		apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1) +		return +	} + +	c.JSON(http.StatusOK, apiStatus) +}  | 
