[chore] Deprecate `with_approval`, `always` (client API), `approvalRequired`, `always` (fedi API) (#4173)

This pull request deprecates `with_approval` and `always` on the client API side, and `approvalRequired` and `always` on the fedi API side, replacing them with `automatic_approval` and `manual_approval` and `automaticApproval` and `manualApproval`, respectively.

Back-compat is kept with these deprecated fields, and they're still serialized to the client API and fedi APIs respectively, in addition to the new non-deprecated properties.

This will stay the case until v0.21.0 when they'll be removed.

For the sake of not doing a massive database migration, the fields are still named `Always` and `WithApproval` in storage. I think this is probably fine!

Part of https://codeberg.org/superseriousbusiness/gotosocial/issues/4026
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4173
Co-authored-by: tobi <tobi.smethurst@protonmail.com>
Co-committed-by: tobi <tobi.smethurst@protonmail.com>

1 files changed, 98 insertions, 0 deletions

diff --git a/internal/api/client/statuses/statusboost_test.go b/internal/api/client/statuses/statusboost_test.go
index 333334bbc..abbe4857b 100644
--- a/internal/api/client/statuses/statusboost_test.go
+++ b/internal/api/client/statuses/statusboost_test.go
@@ -113,6 +113,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reblog": {
@@ -120,6 +125,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reply": {
@@ -127,6 +137,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     }
   },
@@ -168,6 +183,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reblog": {
@@ -175,6 +195,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reply": {
@@ -182,6 +207,11 @@ func (suite *StatusBoostTestSuite) TestPostBoost() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       }
     },
@@ -298,6 +328,13 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
         "mentioned",
         "me"
       ],
+      "automatic_approval": [
+        "author",
+        "followers",
+        "mentioned",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reblog": {
@@ -305,6 +342,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
         "author",
         "me"
       ],
+      "automatic_approval": [
+        "author",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reply": {
@@ -314,6 +356,13 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
         "mentioned",
         "me"
       ],
+      "automatic_approval": [
+        "author",
+        "followers",
+        "mentioned",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     }
   },
@@ -349,6 +398,13 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
           "mentioned",
           "me"
         ],
+        "automatic_approval": [
+          "author",
+          "followers",
+          "mentioned",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reblog": {
@@ -356,6 +412,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
           "author",
           "me"
         ],
+        "automatic_approval": [
+          "author",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reply": {
@@ -365,6 +426,13 @@ func (suite *StatusBoostTestSuite) TestPostBoostOwnFollowersOnly() {
           "mentioned",
           "me"
         ],
+        "automatic_approval": [
+          "author",
+          "followers",
+          "mentioned",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       }
     },
@@ -513,6 +581,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reblog": {
@@ -520,6 +593,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     },
     "can_reply": {
@@ -527,6 +605,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
         "public",
         "me"
       ],
+      "automatic_approval": [
+        "public",
+        "me"
+      ],
+      "manual_approval": [],
       "with_approval": []
     }
   },
@@ -560,6 +643,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reblog": {
@@ -567,6 +655,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       },
       "can_reply": {
@@ -574,6 +667,11 @@ func (suite *StatusBoostTestSuite) TestPostBoostImplicitAccept() {
           "public",
           "me"
         ],
+        "automatic_approval": [
+          "public",
+          "me"
+        ],
+        "manual_approval": [],
         "with_approval": []
       }
     },